-
-
Notifications
You must be signed in to change notification settings - Fork 140
BE: Chore: Bump Spring Boot w/ dependencies #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- mapstruct : 1.5.5.Final -> 1.6.2 - lombok : 1.18.32 -> 1.18.34 - snakeyaml : 2.2 -> 2.3 - spring-boot : 3.1.9 -> 3.3.4 - json : 20231013 -> 20240303 - guava : 33.0.0-jre -> 33.3.1-jre - junit : 5.9.1 -> 5.11.2 - testcontainers : 1.19.5 -> 1.20.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi sixdouglas! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
This PR can help #490 issue |
It looks like I didn't start the |
I've run the tests here, in CI, nothing (new) fails. |
- logback : 1.4.5 -> 1.4.12 - avro : 1.11.3 -> 1.11.4
In deed! I've rollback the changes for CVE. The report looks really good. |
Back to: - logback : 1.4.12 -> 1.5.8
Sorry about my last commit, Spring Boot uses now the 1.5.8 version of Logback, so no need to change its version |
the trivy report still looks good |
@sixdouglas thank you for your first contribution to kafbat UI! |
Bump several frameworks versions
I don't know why yet, but make this
PropertyResolverImplTest
test pass, I needed to change theCustomPropertiesClass
to arecord
! I'm still looking on this issue, though the functionality of mapping properties to custom classes is not used in thekafka-ui
project.I also had to change a little something in the
KsqlApiClientTest
test since Jackson now return DoubleNode instead of DecimalNode. Don't know why either.I let you decide if these differences are breaking changes.
What changes did you make? (Give an overview)
Bump framework versions
mapstruct : 1.5.5.Final -> 1.6.2
lombok : 1.18.32 -> 1.18.34
snakeyaml : 2.2 -> 2.3
spring-boot : 3.1.9 -> 3.3.4
json : 20231013 -> 20240303
guava : 33.0.0-jre -> 33.3.1-jre
junit : 5.9.1 -> 5.11.2
testcontainers : 1.19.5 -> 1.20.2
Is there anything you'd like reviewers to focus on?
All unit tests are OK on my machine, but the smoke tests from the
prod
profile are not. They are failing with this error:I followed the Build and Run with Docker tutorial, the app works locally! I can navigate and see the topics, their characteristics and their content without any issues in the logs as in the UI.
@Haarolean maybe you help me figure out what happens or at least give me some hints on where to look for details?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)