-
-
Notifications
You must be signed in to change notification settings - Fork 140
BE: RBAC: Implement RBAC tests #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi zambrinf! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
@zambrinf could we please add some tests to cover these cases?
If the tests fail due to faulty business logic, we can disable them until the issues are resolved. |
@Haarolean Done. I added a test class |
@Haarolean Are you planning on merging this PR? |
absolutely! Sorry for the delay, I'll be taking a look at this soon - it just takes more cognitive load than other issues/PRs :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your efforts and sorry for the delay. Left a few inline comments, PTAL.
api/src/test/java/io/kafbat/ui/service/rbac/AccessControlServiceRbacEnabledTest.java
Outdated
Show resolved
Hide resolved
api/src/test/java/io/kafbat/ui/service/rbac/AccessControlServiceRbacEnabledTest.java
Outdated
Show resolved
Hide resolved
@zambrinf thank you very much for your contribution! This is a quite important enhancement for us despite being "just tests", as we had a decent amount of issues with RBAC due to lack of the tests. Much appreciated! |
@zambrinf
|
@Haarolean apparently my branch wasn't fully up to date with the main branch, there was a commit |
@zambrinf ah I see, I've recently disabled 'branch should be up to date' merge check for some quick merges. |
What changes did you make? (Give an overview)
Added tests to cober AccessControlService
Closes #729
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)