Skip to content

BE: SR: Fix verifySsl for SR serde #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BE: SR: Fix verifySsl for SR serde #853

wants to merge 1 commit into from

Conversation

Haarolean
Copy link
Member

@Haarolean Haarolean commented Feb 21, 2025 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #854

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean requested a review from a team as a code owner February 21, 2025 10:09
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/serde Serialization & Deserialization (plugins) area/sr Schema Registry status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 21, 2025
@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working labels Feb 21, 2025
germanosin
germanosin reviewed Feb 21, 2025
View reviewed changes
api/src/main/java/io/kafbat/ui/serdes/builtin/sr/SchemaRegistrySerde.java
@@ -166,6 +169,11 @@ private static SchemaRegistryClient createSchemaRegistryClient(List<String> urls
keyStorePassword);
}

if (!verifySsl) { // TODO block above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, what this comment mean. Could you please elaborate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a test change :) ignoring ssl doesn't work for the SR serde, looking for a fix

@fallen-up fallen-up mentioned this pull request Feb 21, 2025
Open
4 tasks
@Haarolean Haarolean marked this pull request as draft February 24, 2025 19:46
@Haarolean Haarolean closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germanosin germanosin germanosin left review comments

Assignees
No one assigned
Labels
area/serde Serialization & Deserialization (plugins) area/sr Schema Registry scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE: SR: Skip SSL for SR
2 participants
@Haarolean @germanosin