-
-
Notifications
You must be signed in to change notification settings - Fork 140
FE: Messages: Fix stack overflow for large messages #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@git-halinka please rebase the PR |
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
Thanks for the additional feedback! We'll get back to your issue soon. |
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
Thanks for the additional feedback! We'll get back to your issue soon. |
@git-halinka please either:
|
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
Co-authored-by: Leshe4ka <kozyurov.alexey@google.com> Co-authored-by: Roman Zabaluev <gpg@haarolean.dev> Co-authored-by: Vlad Senyuta <vlad.senyuta@gmail.com>
c0f3947
to
7f983c8
Compare
No feedback received within 7 days. Auto closing. |
What changes did you make? (Give an overview)
When viewing large messages in AceEditor I was getting: RangeError: Maximum call stack size exceeded
After some googling, it looks like setting wraperEnabled to false fixes the issue
Additionally, I had to set example:
spring.codec.max-in-memory-size: 15MB -- in config.yml
and
max.request.size: 15000000 on cluster preferences when I wanted to be able to produce large messages
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)