Skip to content

FE: Messages: Fix stack overflow for large messages #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

git-halinka
Copy link

image

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
When viewing large messages in AceEditor I was getting: RangeError: Maximum call stack size exceeded
After some googling, it looks like setting wraperEnabled to false fixes the issue
Additionally, I had to set example:
spring.codec.max-in-memory-size: 15MB -- in config.yml
and
max.request.size: 15000000 on cluster preferences when I wanted to be able to produce large messages

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@git-halinka git-halinka requested a review from a team as a code owner March 12, 2025 11:28
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/messages status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 12, 2025
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress labels Mar 14, 2025
@Haarolean Haarolean added this to the 1.2 milestone Mar 14, 2025
@Haarolean
Copy link
Member

@git-halinka please rebase the PR

Copy link

kapybro bot commented Mar 18, 2025

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@Haarolean Haarolean removed this from the 1.2 milestone Mar 19, 2025
@Haarolean Haarolean removed this from Release 1.2 Mar 19, 2025
Copy link

kapybro bot commented Mar 20, 2025

Thanks for the additional feedback! We'll get back to your issue soon.

Copy link

kapybro bot commented Mar 20, 2025

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@git-halinka git-halinka requested review from a team as code owners March 20, 2025 19:13
Copy link

kapybro bot commented Mar 20, 2025

Thanks for the additional feedback! We'll get back to your issue soon.

@Haarolean Haarolean requested review from Haarolean and removed request for a team March 21, 2025 11:43
@Haarolean Haarolean changed the title fix large messages FE: Messages: Fix stack overflow for large messages Mar 21, 2025
@Haarolean Haarolean added this to the 1.2 milestone Mar 21, 2025
@Haarolean
Copy link
Member

@git-halinka please either:

  1. rebase the PR so a fast-forward merge is possible (no other unrelated commits present in main are present in your branch)
  2. or check the 'maintainers has access to the PR' on the right side of the PR so we can do this for you

Copy link

kapybro bot commented Mar 21, 2025

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@Haarolean Haarolean removed this from the 1.2 milestone Mar 21, 2025
@Haarolean Haarolean removed this from Release 1.2 Mar 21, 2025
git-halinka and others added 3 commits March 21, 2025 16:27
Co-authored-by: Leshe4ka <kozyurov.alexey@google.com>
Co-authored-by: Roman Zabaluev <gpg@haarolean.dev>
Co-authored-by: Vlad Senyuta <vlad.senyuta@gmail.com>
@git-halinka git-halinka force-pushed the editor-larg-message branch from c0f3947 to 7f983c8 Compare March 21, 2025 16:30
Copy link

kapybro bot commented Mar 25, 2025

No feedback received within 7 days. Auto closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/messages scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants