Various fixes to LVM2 #720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnet
commented
Sep 12, 2025
maxnet
commented
- fixes 'repeat-until' lines to test for end of values correctly
- fixes endless recursion while reading metadata_area_header checksum field
- fixes instructions to create example file. Closes LVM2 definition instructions for building a test file does not work #295
- fixes reading from absolute offsets in file
- adds instance to read the LVM2 text metadata from raw location descriptor
- fixes 'repeat-until' lines to test for end of values correctly - fixes endless recursing while reading checksum field - fixes instructions to create example file. Closes kaitai-io#295 - fixes reading from absolute positions in file - adds instance to read the LVM2 text metadata from raw location descriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.