Skip to content

Phonetisaurus no longer works #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danijel3 opened this issue Nov 26, 2024 · 6 comments
Open

Phonetisaurus no longer works #4961

danijel3 opened this issue Nov 26, 2024 · 6 comments
Labels

Comments

@danijel3
Copy link
Contributor

Just a wanted to point out that Phonetisaurus stopped compiling with the newest version of OpenFST. That means that the script ${KALDI_ROOT}/tools/extras/intall_phonetisaurus.sh is no longer functional.

The reason for this is that Phonetisaurus hasn't been updated in 4 years and the last working version of OpenFST at that time was 1.8.0 /1.8.1. I made a PR that makes some fixes and allows it to compile: AdolfVonKleist/Phonetisaurus#89 but I doubt it will get merged into master anytime soon (just as 8 other PRs in the last 4 years).

There are 3 solutions, IMO:

  • remove the script altogether
  • make a Phonetisaurus fork
  • make a note somewhere (perhaps in the script) that it works with OpenFST 1.8.0 - if someone really cares, they can have both versions of OpenFST in the tools directory as the codebase isn't mixed with Kaldi anyway (it's used only in scripts)
@danijel3 danijel3 added the bug label Nov 26, 2024
Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

@stale stale bot added the stale Stale bot on the loose label Apr 26, 2025
@danijel3
Copy link
Contributor Author

I'll gladly make a PR, but would like to know which one of the above would be best suited here.

@stale stale bot removed the stale Stale bot on the loose label Apr 26, 2025
@danpovey
Copy link
Contributor

danpovey commented May 2, 2025

@danijel3 Is it possible to modify the phonetisaurus installation script so that it manually pulls your fix?

@danijel3
Copy link
Contributor Author

danijel3 commented May 2, 2025

Sure, I can maintain a "compile-able" fork of Phonetisairus. I don't mind if we put it under any other namespace/org/user, but it can be my account if that's okay.

@danpovey
Copy link
Contributor

danpovey commented May 2, 2025

Your account is fine.

@danijel3
Copy link
Contributor Author

danijel3 commented May 2, 2025

Cool. I'll clean up the repo and make a PR asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants