Error when upgrading to Apollo 3.

[Eraldo]

ERROR in src/app/core/graphql/graphql.module.ts:49:28 - error TS2322: Type 'ApolloNetworkStatus' is not assignable to type 'ApolloLink | RequestHandler'.
  Property 'setOnError' is missing in type 'ApolloNetworkStatus' but required in type 'ApolloLink'.

49     link: ApolloLink.from([networkStatus, link]),
                              ~~~~~~~~~~~~~

  node_modules/@apollo/client/link/core/ApolloLink.d.ts:15:5
    15     setOnError(fn: (reason: any) => any): this;
           ~~~~~~~~~~
    'setOnError' is declared here.
ERROR in src/app/core/graphql/graphql.module.ts:49:28 - error TS2322: Type 'ApolloNetworkStatus' is not assignable to type 'ApolloLink | RequestHandler'.
  Property 'setOnError' is missing in type 'ApolloNetworkStatus' but required in type 'ApolloLink'.

49     link: ApolloLink.from([networkStatus, link]),
                              ~~~~~~~~~~~~~

  node_modules/@apollo/client/link/core/ApolloLink.d.ts:15:5
    15     setOnError(fn: (reason: any) => any): this;
           ~~~~~~~~~~
    'setOnError' is declared here.

Versions:

• "apollo-angular": "^2.0.3",
• "apollo-angular-link-network-status": "^1.0.4",

[kamilkisiela]

It doesn't support @apollo/client, a simple PR that replaces apollo-link with @apollo/client/core should be the only migration needed. I will happily accept and merge it.

[Eraldo]

Update: As soon as PR #6 will be merged and released, this issue will hopefully be done. :)

[Eraldo]

Tried it again today.
Getting this error message:

TS2322: Type 'ApolloNetworkStatus' is not assignable to type 'ApolloLink | RequestHandler'.   Type 'ApolloNetworkStatus' is missing the following properties from type 'ApolloLink': split, concat, setOnError

[Eraldo]

index.d.ts contains this line: import { ApolloLink, Operation, FetchResult, Observable as LinkObservable } from 'apollo-link';
Seems like this is still an old import, right @kamilkisiela ?

Using latest: "apollo-angular-link-network-status": "^1.0.4",

[Eraldo]

I just realised that 1.0.4 is the same version where the issue originally occurred. ^^
So I guess you just did not find the time to do the new release yet, is that the case?
kamilkisiela/apollo-angular#1555 (comment)

[Eraldo]

I forked and tried if I can get it to run with your changes @kamilkisiela.
(To see if the release is the only step missing.)
Seems like the signature of onError also changed => onError(reason: any): void;.

[Eraldo]

@kamilkisiela Any hope of this moving forward? :)

[Eraldo]

@kamilkisiela Ping. :)
(Heartbeat in the hope to keep the issue alive.)

[Eraldo]

Any updates @kamilkisiela ?

[Eraldo]

Any updates?

[Eraldo]

Any hopes/outlook of things moving forward?

[Eraldo]

@kamilkisiela any update? 🙏
Other ways of how I can do the same thing without that package maybe?

[Eraldo]

Shall I give up hope? 😅

[Eraldo]

@kamilkisiela ?