Skip to content

Whether Karmada can enable the agent to register cluster with labels and annotations #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Shuanglu opened this issue Feb 28, 2025 · 5 comments · May be fixed by #6172
Open

Whether Karmada can enable the agent to register cluster with labels and annotations #6175

Shuanglu opened this issue Feb 28, 2025 · 5 comments · May be fixed by #6172
Labels
kind/question Indicates an issue that is a support question.

Comments

@Shuanglu
Copy link

Shuanglu commented Feb 28, 2025 •
edited
Loading

Please provide an in-depth description of the question you have:
There seems to be no option to use the agent to directly register the cluster with label/annotation. It adds the operation overhead that the label/annotation needs to be added after cluster register
What do you think about this question?:

Environment:

  • Karmada version: 1.12
  • Kubernetes version: 1.30
  • Others:
@Shuanglu Shuanglu added the kind/question Indicates an issue that is a support question. label Feb 28, 2025
@RainbowMango
Copy link
Member

Yes, that's true. Want to share more details about what kind of label/annotation you want to add during the cluster registration? And why?

@Shuanglu
Copy link
Author

Shuanglu commented Mar 1, 2025

Yes, that's true. Want to share more details about what kind of label/annotation you want to add during the cluster registration? And why?

It's not about the specific label/annotation but the capability to allow user to do so. E.g. in this doc, the clusters with specific region label are selected. If the label can be added when the cluster is registered, it would be great. My understanding is that Karmada-agent currently only create cluster object without label and we need to label the cluster by ourselves later.
The implememtation could be something like this

@RainbowMango
Copy link
Member

OK. I see. It makes sense to me. I will take a look #6172 and leave my comments there.

By the way, have you noticed the --cluster-provider, --cluster-region, and --cluster-zones from karmada-agent, they also can be used to select clusters by the FieldSelector in PropagationPolicy?

@Shuanglu
Copy link
Author

Shuanglu commented Mar 1, 2025

OK. I see. It makes sense to me. I will take a look #6172 and leave my comments there.

By the way, have you noticed the --cluster-provider, --cluster-region, and --cluster-zones from karmada-agent, they also can be used to select clusters by the FieldSelector in PropagationPolicy?

Thanks. I noticed that. I just feel like there is no reason to block user to register the cluster with the customized metadata ( or there is reason I'm not aware of 😄

@Shuanglu Shuanglu linked a pull request Mar 1, 2025 that will close this issue
Open
@RainbowMango
Copy link
Member

Haha, I'm always open to new features, but I always ask and learn the use case first, to make sure our effort is for a real-world problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/question Indicates an issue that is a support question.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] allow agent to register cluster with labels and annotations Shuanglu/karmada
2 participants
@Shuanglu @RainbowMango