-
Notifications
You must be signed in to change notification settings - Fork 937
standardize the naming of karmada secrets #6178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
standardize the naming of karmada secrets #6178
Conversation
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Am I doing right, so far? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6178 +/- ##
==========================================
- Coverage 47.95% 47.95% -0.01%
==========================================
Files 674 674
Lines 55841 55841
==========================================
- Hits 26781 26776 -5
- Misses 27311 27315 +4
- Partials 1749 1750 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sorry for late
yes, as for point number 1, you are on the right track. the next steps you should do are:
then you may achieve point number 1, this part is not too complicated, you can do it boldly~ |
Sure let me finalize for point number 1, but I'm confused on how to rename the secret, could you give me an example |
Don't worry, let's take it step by step, and complete the point number 1 first. ps: I'm very sorry for the slow reply because I've been busy with other things recently. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #6051
Special notes for your reviewer:
Does this PR introduce a user-facing change?: