-
Notifications
You must be signed in to change notification settings - Fork 940
Update bind addresses to use POD_IP for helm #6324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6324 +/- ##
==========================================
- Coverage 48.44% 48.42% -0.03%
==========================================
Files 677 677
Lines 56067 56067
==========================================
- Hits 27164 27151 -13
- Misses 27123 27134 +11
- Partials 1780 1782 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @seanlaii have you installed it with the modified content? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the listening addresses for multiple components (metrics adapter, webhook, etc.) to use the Pod's IP address via the
POD_IP
environment variable. By binding to the specific Pod IP rather than a generic address like0.0.0.0
, the components are restricted to listening only on their assigned network interface. This improves security by reducing exposure and ensures that metrics and health probes are correctly bound to the right interface, aiding in more predictable network behavior.Which issue(s) this PR fixes:
Part of #6266
Special notes for your reviewer:
Does this PR introduce a user-facing change?: