Skip to content

Update bind addresses to use POD_IP for helm #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

seanlaii
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates the listening addresses for multiple components (metrics adapter, webhook, etc.) to use the Pod's IP address via the POD_IP environment variable. By binding to the specific Pod IP rather than a generic address like 0.0.0.0, the components are restricted to listening only on their assigned network interface. This improves security by reducing exposure and ensures that metrics and health probes are correctly bound to the right interface, aiding in more predictable network behavior.

Which issue(s) this PR fixes:
Part of #6266

Special notes for your reviewer:

  • The changes affect all relevant deployments.
  • Ensure that after these changes, all inter-component communications (e.g., metrics scrape, liveness, and readiness probes) continue to work as expected.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 25, 2025
@karmada-bot karmada-bot requested review from a7i and zhzhuang-zju April 25, 2025 21:19
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.42%. Comparing base (c31c8e4) to head (71cedc7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6324      +/-   ##
==========================================
- Coverage   48.44%   48.42%   -0.03%     
==========================================
  Files         677      677              
  Lines       56067    56067              
==========================================
- Hits        27164    27151      -13     
- Misses      27123    27134      +11     
- Partials     1780     1782       +2     
Flag Coverage Δ
unittests 48.42% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XiShanYongYe-Chang
Copy link
Member

Hi @seanlaii have you installed it with the modified content?

@seanlaii
Copy link
Contributor Author

Yes, it works locally. This is the image of the local pod statuses:
image

I first used hack/setup-dev-base.sh and installed the helm chart.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@karmada-bot karmada-bot merged commit 1381a58 into karmada-io:master Apr 28, 2025
24 checks passed
@seanlaii seanlaii deleted the helm-pod-ip branch April 28, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants