Skip to content

fix: remove 'ValueError' from return union for 'wrap_constant' #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove 'ValueError' from return union for 'wrap_constant' #769

wants to merge 1 commit into from

Conversation

vkcku
Copy link

@vkcku vkcku commented Nov 13, 2023

This removes the ValueError from the union in the return type of Term.wrap_constant.

@vkcku vkcku requested a review from a team as a code owner November 13, 2023 06:37
williambdean
williambdean approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@williambdean williambdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Any thoughts @AzisK ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@williambdean williambdean williambdean approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkcku @williambdean