Skip to content

refactor: update interval to inherit from term #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: update interval to inherit from term #838

wants to merge 1 commit into from

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented May 26, 2025 •
edited
Loading

Description

  • Simplify typing of wrap_json
  • Make Interval a subclass of Term. It doesn't seem like there is reason it should be a subclass of Node. This helps with simplifying typing.

@waketzheng waketzheng requested a review from a team as a code owner May 26, 2025 04:12
@coveralls
Copy link

Coverage Status

coverage: 98.434%. remained the same
when pulling 80accfe on waketzheng:interval-from-term
into 1c9646f on kayak:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waketzheng @coveralls