Skip to content

Conversation

briehl
Copy link
Member

@briehl briehl commented Mar 5, 2025

Description of PR purpose/changes

Combines and annotates dependabot suggestions for Python and JS updates.

  • Please include a summary of the change and which issue is fixed.
  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-X

  • Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • (Python) I have run Ruff format and check on changed Python code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

Copy link
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing God's work.

ETA: Didn't notice the bit about the JS changes. I will recheck the PR when they are in place.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.89%. Comparing base (533b609) to head (bed85bb).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3684      +/-   ##
===========================================
- Coverage    25.90%   25.89%   -0.01%     
===========================================
  Files          461      461              
  Lines        46653    46653              
===========================================
- Hits         12085    12082       -3     
- Misses       34568    34571       +3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e360ac...bed85bb. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@briehl
Copy link
Member Author

briehl commented Mar 11, 2025

@ialarmedalien and I think it works now.

Comment on lines +196 to +200
'--headless',
'--no-sandbox',
'--disable-gpu',
'--disable-dev-shm-usage',
`--window-size=${config.WIDTH},${config.HEIGHT}`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were wrong and causing headless chrome to fail when run as root, like in the test container.

@briehl briehl requested a review from ialarmedalien March 11, 2025 19:49
Copy link

@briehl briehl merged commit c6e0a89 into develop Mar 17, 2025
17 of 19 checks passed
@briehl briehl deleted the dep-updates-march-2025 branch March 17, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants