fix tests, remove profile DNE err

Author: dauglyon

src/features/profile/profileSlice.test.tsx

@@ -1,7 +1,6 @@
 import { render, waitFor } from '@testing-library/react';
 import fetchMock from 'jest-fetch-mock';
 import { FetchMock } from 'jest-fetch-mock/types';
-import { ErrorBoundary } from 'react-error-boundary';
 import { Provider } from 'react-redux';
 import { createTestStore } from '../../app/store';
 import { makeKBaseServices } from '../../test/kbaseServiceMock';
@@ -39,30 +38,4 @@ describe('useLoggedInProfileUser', () => {
       )
     );
   });
-
-  test('throws error when called with invalid username', async () => {
-    const onErr = jest.fn();
-    const consoleError = jest.spyOn(console, 'error');
-    // eslint-disable-next-line @typescript-eslint/no-empty-function
-    consoleError.mockImplementation(() => {});
-    const Component = () => {
-      useLoggedInProfileUser('not_a_user');
-      return <></>;
-    };
-    render(
-      <ErrorBoundary fallback={<></>} onError={onErr}>
-        <Provider store={testStore}>
-          <Component />
-        </Provider>
-      </ErrorBoundary>
-    );
-    await waitFor(() => {
-      expect(onErr).toHaveBeenCalled();
-      expect(consoleError).toHaveBeenCalled();
-    });
-    expect(testStore.getState().profile.loggedInProfile?.user.username).toBe(
-      undefined
-    );
-    consoleError.mockRestore();
-  });
 });

src/features/profile/profileSlice.ts

@@ -47,18 +47,28 @@ export const useLoggedInProfileUser = (username?: string) => {
   );
 
   useEffect(() => {
-    if (query.isSuccess) {
+    if (query.isSuccess && query.data) {
       // Set the logged in profile once it loads
       // If profile DNE, (eg auth service local user), set profile to undefined
-      if (!query.data[0][0]) {
-        dispatch(setLoggedInProfile(undefined));
-      } else if (query.data[0][0].user.username !== profileUser) {
+      const queryUsername = query.data?.[0]?.[0]?.user?.username;
+      if (query.data[0][0] && queryUsername === username) {
         dispatch(setLoggedInProfile(query.data[0][0]));
-      } else {
-        throw new Error('loading profile failed');
+      } else if (!query.data[0][0]) {
+        // likely a local user, no profile!
+        setLoggedInProfile(undefined);
       }
     }
-  }, [dispatch, profileUser, query.data, query.error, query.isSuccess]);
+    if (query.error) {
+      throw query.error;
+    }
+  }, [
+    dispatch,
+    profileUser,
+    query.data,
+    query.error,
+    query.isSuccess,
+    username,
+  ]);
 
   return query;
 };