Skip to content

Conversation

Xiangs18
Copy link
Contributor

No description provided.

@Xiangs18 Xiangs18 requested a review from MrCreosote June 16, 2025 20:07
@MrCreosote
Copy link
Member

Looks like the tests are failing

@MrCreosote
Copy link
Member

Changes look ok other than the same note as prior reviews re the time not really being necessary, but fine

@Xiangs18
Copy link
Contributor Author

The test failures are not related to this update.
#749 (comment)

@MrCreosote
Copy link
Member

Are the handle service and sample service still on 3.7? If they've been updated, try (in a different PR) to update the ubuntu version and the python version to see if the test pass. If they do, we can merge that and then rerun the tests here.

If not or the python version is still too low, then we should convert the workspace repo to uv and use it to install the necessary python version. There's an example here kbase/kb_sdk_plus#81

@MrCreosote
Copy link
Member

Also if the services' dependencies have been updated they should be synced here come to think of it

@Xiangs18
Copy link
Contributor Author

Xiangs18 commented Jul 11, 2025

Looks like the tests are failing

ws test fail fixed by this pr: #751

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (325125b) to head (e0ce37e).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #750   +/-   ##
==========================================
  Coverage      87.78%   87.78%           
  Complexity      5328     5328           
==========================================
  Files            228      228           
  Lines          17598    17598           
  Branches        2585     2585           
==========================================
  Hits           15448    15448           
  Misses          1694     1694           
  Partials         456      456           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Xiangs18 Xiangs18 merged commit f97f21e into develop Jul 11, 2025
15 checks passed
@Xiangs18 Xiangs18 deleted the dev-update_dependabot branch July 11, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants