Update test.yml and fix failed tests #751
Conversation
|
@MrCreosote Any idea what might be causing the Sample Service connection refused? |
|
Not off the top of my head, you'll need to check the sample service logs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #751 +/- ##
==========================================
Coverage 87.78% 87.78%
Complexity 5328 5328
==========================================
Files 228 228
Lines 17598 17598
Branches 2585 2585
==========================================
Hits 15448 15448
Misses 1694 1694
Partials 456 456 🚀 New features to boost your workflow:
|
| # sample service dependencies | ||
| python-arango = "==5.0.0" | ||
| apscheduler = "==3.6.3" | ||
| apscheduler = "==3.11.0" | ||
| maps = "==5.1.1" | ||
| cacheout = "==0.11.2" | ||
| pyyaml = "==5.3" | ||
| jsonschema = "==3.2.0" | ||
| pint = "==0.10.1" | ||
| pint = "==0.17" | ||
| python-ranges = "==0.1.3" | ||
| pygtrie = "==2.3.2" | ||
| jinja2 = "==2.11.2" | ||
| gevent = "==20.5.0" | ||
| gunicorn = "==20.0.4" | ||
| gevent = "==24.11.1" | ||
| gunicorn = "==20.1.0" | ||
| kafka-python = "==2.0.1" | ||
| greenlet = "==0.4.16" | ||
| greenlet = "==3.1.1" | ||
| typing-extensions = "*" |
There was a problem hiding this comment.
These are all the same as what's current in sample service?
There was a problem hiding this comment.
Looking at https://github.com/kbase/sample_service/blob/develop/Pipfile:
apscheduler = "==3.9.1"
cacheout = "==0.13.1"
pyyaml = "==6.0"
python-ranges = "==0.2.0"
pygtrie = "==2.4.2"
jinja2 = "==3.1.1"
kafka-python = "==2.0.2"
types-pyyaml = "==6.0.7"
types-requests = "==2.27.20"
shell = "==1.0.1"
.. are different. Am I looking in the wrong place?
There was a problem hiding this comment.
The dependency updates I made align with those currently used in the Sample Service, except for apscheduler. I can downgrade it to version 3.9.1 if preferred, but the original version is clearly causing issues.
There was a problem hiding this comment.
So why is the pipfile in develop different?
There was a problem hiding this comment.
Fixed. Now I'm not sure if I left something out...
There was a problem hiding this comment.
I've double-checked - it should be correct now.
There was a problem hiding this comment.
Can you add those notes as comments into the pipfile please?
Done
There was a problem hiding this comment.
Please just put the justifications for the deviations directly in the pipfile
|
Self-note: The file /lib/biokbase/log.py already exists in Handle Service v1.0.7, so there's no need to retrieve it separately from https://raw.githubusercontent.com/kbase/sdkbase2 - it's the same file. |
No description provided.