Skip to content

Commit 93f9bd8

Browse files
Wip/refactor/message refactor (#143)
* Added the rule of 5 to message class * Featurebranch patch - add dynamic allocation in test to avoid direct destructor call * Patch test
1 parent b7f4a55 commit 93f9bd8

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

tests/gtest/test_serialization.cpp

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -102,23 +102,24 @@ TEST(TEST_SERIALIZATION, TEST_MESSAGE_TAG) {
102102

103103
TEST(TEST_SERIALIZATION, TEST_MESSAGE_SPLIT) {
104104
const char* message = "Hello World!";
105-
Networking::AxonMessage message_( const_cast<char*> ( message ), strlen(message) + 1, 0);
105+
auto * message_ = new Networking::AxonMessage( const_cast<char*> ( message ), strlen(message) + 1, 0);
106106

107-
ASSERT_STREQ(static_cast<char*>(message_.getMessage()), "Hello World!");
108-
Networking::AxonMessage::UniqueAxonMessagePtr ptr = message_.split(5);
107+
ASSERT_STREQ(static_cast<char*>(message_->getMessage()), "Hello World!");
108+
Networking::AxonMessage::UniqueAxonMessagePtr ptr = message_->split(5);
109109

110110
ASSERT_TRUE(ptr.get());
111111
ASSERT_EQ(ptr->getSize(), 8);
112-
ASSERT_EQ(message_.getSize(), 5);
112+
ASSERT_EQ(message_->getSize(), 5);
113113

114-
ASSERT_STREQ(static_cast<char*>(message_.getMessage()), "Hello World!");
114+
ASSERT_STREQ(static_cast<char*>(message_->getMessage()), "Hello World!");
115115

116-
ASSERT_TRUE(message_.hasFlag(Networking::PARTIAL));
116+
ASSERT_TRUE(message_->hasFlag(Networking::PARTIAL));
117117
ASSERT_FALSE(ptr->hasFlag(Networking::PARTIAL));
118118

119-
ASSERT_EQ(message_.ID(), ptr->ID());
120-
ASSERT_EQ(message_.getPartID() + 1, ptr->getPartID());
119+
ASSERT_EQ(message_->ID(), ptr->ID());
120+
ASSERT_EQ(message_->getPartID() + 1, ptr->getPartID());
121+
122+
delete message_;
121123

122-
message_.~AxonMessage();
123124
ASSERT_STREQ(static_cast<char*>(ptr->getMessage()), " World!");
124125
}

0 commit comments

Comments
 (0)