Skip to content

feature: wait for APIExport to become available #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
gman0 opened this issue Mar 9, 2025 · 2 comments
Open
1 task

feature: wait for APIExport to become available #37

gman0 opened this issue Mar 9, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gman0
Copy link

gman0 commented Mar 9, 2025

Feature Description

If the syncing APIExport is not available in the source cluster, api-syncagent exits immediately. This behavior breaks workflows where the user wants to start up pods / bins before creating APIExports.

Proposed Solution

Instead, the agent could wait indefinitely until the resource becomes available (maybe with a separate --wait-for-apiexport-exists flag).

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@gman0 gman0 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2025
@gman0
Copy link
Author

gman0 commented Mar 9, 2025

I can work on this sometime during the week if maintainers agree this makes sense.

@xrstf
Copy link
Contributor

xrstf commented Mar 11, 2025

I am not sure it's worth or wise to complicate the code with a wait loop. The agent is configured to sync a given APIExport, and this export doesn't exist. That is an (human) error and instead of hiding that in a silent forever-running wait loop, I much rather prefer the Pod to go into a CrashLoop, something that is detectable with monitoring tools like Prometheus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants