-
Notifications
You must be signed in to change notification settings - Fork 6
0002: Add mounts proposal #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have 2 areas where this might be implemented, and I don't quite like it.
root-4 is manually created workspace in home workspace. By executing I somehow think that we could do this with mounts too where users would still need to create workspace, but mount something ontop. This way we could route traffic to it via index. But there is caviate - there is no redirect as such as now So to make it really redirect - we need would need to instruct client tooling to know that is just just override url in kubeconfig, over using I would like to keep handing of different mounts at the proxy layer. Maybe try 301 response to kubectl and force somehow plugin to handle change? Or something under these lines... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comment that doesn't match any section right now: Can we describe how authN/authZ works in this? I understand that the backend is out of scope, but what kind of data is kcp sending to the proxy backend? Is the backend responsible for resolving authN/authZ?
TODO: Summarise this here too https://kubernetes.slack.com/archives/C021U8WSAFK/p1712597717851069 |
Will add this as non-goal as this is the responsibility of implementers to arrange this either by federating identities or other means |
Proposal for Mounts API