Add FF to disable URL population.

Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT>
On-behalf-of: @SAP mangirdas.judeikis@sap.com

Author: mjudeikis

pkg/features/kcp_features.go

@@ -42,6 +42,12 @@ const (
 	// alpha: v0.1
 	// Enables workspace mounts via frontProxy.
 	WorkspaceMounts featuregate.Feature = "WorkspaceMounts"
+
+	// owner: @mjudeikis
+	// alpha: v0.1
+	// Enables Poplaing VirtualWorkspace urls on APIExport. This enables to use Deprecated APIExport VirtualWorkspace urls.
+	// This is a temporary feature to ease the migration to the new VirtualWorkspace urls.
+	EnableDeprecatedAPIExportVirtualWorkspacesUrls featuregate.Feature = "EnableDeprecatedAPIExportVirtualWorkspacesUrls"
 )
 
 // DefaultFeatureGate exposes the upstream feature gate, but with our gate setting applied.
@@ -112,7 +118,9 @@ var defaultVersionedGenericControlPlaneFeatureGates = map[featuregate.Feature]fe
 	WorkspaceMounts: {
 		{Version: version.MustParse("1.28"), Default: false, PreRelease: featuregate.Alpha},
 	},
-
+	EnableDeprecatedAPIExportVirtualWorkspacesUrls: {
+		{Version: version.MustParse("1.32"), Default: false, PreRelease: featuregate.Alpha},
+	},
 	// inherited features from generic apiserver, relisted here to get a conflict if it is changed
 	// unintentionally on either side:
 

pkg/reconciler/apis/apiexport/apiexport_reconcile.go

@@ -22,6 +22,7 @@ import (
 	"net/url"
 	"path"
 
+	kcpfeatures "github.com/kcp-dev/kcp/pkg/features"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -111,15 +112,18 @@ func (c *controller) reconcile(ctx context.Context, apiExport *apisv1alpha2.APIE
 		}
 	*/
 
-	if err := c.updateVirtualWorkspaceURLs(ctx, apiExport); err != nil {
-		conditions.MarkFalse(
-			apiExport,
-			apisv1alpha2.APIExportVirtualWorkspaceURLsReady,
-			apisv1alpha2.ErrorGeneratingURLsReason,
-			conditionsv1alpha1.ConditionSeverityError,
-			"%v",
-			err,
-		)
+	// TODO(mjudeikis): Remove this and move to batteries.
+	if !kcpfeatures.DefaultFeatureGate.Enabled(kcpfeatures.EnableDeprecatedAPIExportVirtualWorkspacesUrls) {
+		if err := c.updateVirtualWorkspaceURLs(ctx, apiExport); err != nil {
+			conditions.MarkFalse(
+				apiExport,
+				apisv1alpha2.APIExportVirtualWorkspaceURLsReady,
+				apisv1alpha2.ErrorGeneratingURLsReason,
+				conditionsv1alpha1.ConditionSeverityError,
+				"%v",
+				err,
+			)
+		}
 	}
 
 	return nil