Improvements for webhooks docs and tests #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
We'll need a look at TestAPIBindingPermissionClaimsVerbs \o/ |
gman0
force-pushed
the
admissionwebhooks-tests-and-docs
branch
from
c210356 to
7629778
Compare
gman0
force-pushed
the
admissionwebhooks-tests-and-docs
branch
from
7629778 to
4858b0b
Compare
embik
requested changes
May 26, 2025
On-behalf-of: @SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
gman0
force-pushed
the
admissionwebhooks-tests-and-docs
branch
from
4858b0b to
a2f5d62
Compare
embik
reviewed
May 26, 2025
|
LGTM label has been added. Git tree hash: bd1e9a5a384e7d79d6a1ef55e3324ba53837a816
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds more checks for apibinding webhook tests. Also adds docs to note down the behavior of kcp's webhook admission plugins.
What Type of PR Is This?
/kind documentation
Related Issue(s)
Fixes #3294
Release Notes