btrfsmaintenance: add tests framework and functional test cases #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a framework to test btrfsmaintenance.
This test environment needs the following variables configured in the
file './check'.
TESTPATH
Specify the path to the btrfsmaintenance code under test.
For example:
TESTPATH=/usr/share/btrfsmaintenance # Tests the rpm installed code.
TESTPATH=../ # Tests script from the btrfsmaintenance workspace.
SCRATCH_MNT
Provide a scratch btrfs filesystem for which the scripts run.
For example:
SCRATCH_MNT=/mnt/scratch
Run tests as:
./check <-- runs all the available test cases.
./check 1-timer-systemd.sh <-- runs only the specified test case.
As of now, there are a set of 6 test cases to test the anacron,
systemd timers setups and the task scripts using a configuration
file 'sysconfig.btrfsmaintenance.testall'.
Please note, this adds the basic functionality test cases more
elaborate test cases to be added based on the feedback.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
We specify the top-level directory in the btrfsmaintenance config file. Why not add -r recursive option. Signed-off-by: Anand Jain <anand.jain@oracle.com>
The default values of these tasks are entirely system dependent. Larger servers are fine; however, balance or scrub on small RPi stalls the system. And the users without being aware of such an impact will have bad experiences. Defaults to none help use cases to review. Signed-off-by: Anand Jain <anand.jain@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a framework to test btrfsmaintenance.
This test environment needs the following variables configured in the
file './check'.
TESTPATH
Specify the path to the btrfsmaintenance code under test.
For example:
TESTPATH=/usr/share/btrfsmaintenance # Tests the rpm installed code.
TESTPATH=../ # Tests script from the btrfsmaintenance workspace.
SCRATCH_MNT
Provide a scratch btrfs filesystem for which the scripts run.
For example:
SCRATCH_MNT=/mnt/scratch
Run tests as:
./check <-- runs all the available test cases.
./check 1-timer-systemd.sh <-- runs only the specified test case.
As of now, there are a set of 6 test cases to test the anacron,
systemd timers setups and the task scripts using a configuration
file 'sysconfig.btrfsmaintenance.testall'.
Please note, this adds the basic functionality test cases more
elaborate test cases to be added based on the feedback.
Signed-off-by: Anand Jain anand.jain@oracle.com