Skip to content

Transition to consistent package linking #24

@nkuba

Description

@nkuba

Currently, we've got multiple ways of linking packages between local repos:

  1. npm link

    cd $WORKDIR/keep-core/solidity
    npm link
    cd $WORKDIR/keep-ecdsa/solidity
    npm link
    cd $WORKDIR/tbtc/solidity
    npm link
    printf "${LOG_START}Updating Keep Dashboard configuration...${LOG_END}"
    cd $WORKDIR/keep-core/solidity/dashboard
    npm link @keep-network/keep-core
    npm link @keep-network/keep-ecdsa
    npm link @keep-network/tbtc

  2. Replacing node_modules content

    rm -rf keep-ecdsa/solidity/node_modules/@keep-network/keep-core
    cp -R keep-core/solidity/. keep-ecdsa/solidity/node_modules/@keep-network/keep-core

  3. Replacing the dependency path in package.json

    TBTC_DIR="$WORKDIR/tbtc/solidity" jq '.dependencies."@keep-network/tbtc" = env.TBTC_DIR' package.json > package.json.tmp && mv package.json.tmp package.json

We should be consistent across install scripts (preferably use the first way).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions