Skip to content

Add compatibility for Safari Web Extension #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

sebastianlivoni
Copy link

@sebastianlivoni sebastianlivoni commented Apr 11, 2025

This pull request adds compatibility for use in a Safari Web Extension. The idea is to embed this keepassxc-browser extension within the KeePassXC app on macOS. The pull request for this is here.

Non-supported features in Safari Web Extension:

  • The ability to change keyboard shortcuts dynamically (showing unsupported info dialog for this)
  • Autofill HTTP Auth dialogs (showing unsupported info dialog for this)
  • Show notifications for errors when user interaction is required. (hiding this option)

Screenshots or videos

image

image

Testing strategy

  • Conducted progressively as development continued.

Type of change

  • ✅ New feature (change that adds functionality)

@varjolintu
Copy link
Member

Few things to fix in the files:

  • Leave the empty line change at the end
  • Use single quotes ' instead of "
  • Use translations in the HTML files instead of plain English text

@phoerious
Copy link
Member

Also, can we use our dark-theme logo for dark toolbar backgrounds? Simply inverting the light-theme logo doesn't work.

@sebastianlivoni sebastianlivoni changed the title Adds compatibility for Safari Web Extension Add compatibility for Safari Web Extension Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants