Fix showing correct checkbox value in entry Browser Integration settings#12980
Open
varjolintu wants to merge 1 commit intokeepassxreboot:developfrom
Open
Fix showing correct checkbox value in entry Browser Integration settings#12980varjolintu wants to merge 1 commit intokeepassxreboot:developfrom
varjolintu wants to merge 1 commit intokeepassxreboot:developfrom
Conversation
varjolintu
added
user interface
feature: Browser
pr: bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes showing the correct checkbox value in entry's Browser Integration settings page. Also checks that the group setting is inherited before checking the entry's own value in BrowserService. Group settings can override the entry options.
For checkbox values, the group's enabled/disabled value is now checked by the new
resolveBrowserOptionEnabled()function.Testing strategy
Automatic tests made for the URL matching. Manually tested the UI by checking all possible scenarios:
Type of change