Fix FDO Secrets GUI test crashes#13311
Open
droidmonkey wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts GUI test event processing to prevent crashes in the FDO Secrets GUI tests (fixes #13307), by changing how Qt events/timers are pumped during dialog-driving flows.
Changes:
- Simplifies
TestGuiFdoSecrets::processEvents()to callQApplication::processEvents(). - Adds an extra event-processing pass before driving the access control dialog to help queued timers fire.
droidmonkey
force-pushed
the
fix/fdosecrets-gui-test
branch
from
98f5890 to
fd22a32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested in a debugger, need end user testing to confirm fix. @WhyNotHugo
Type of change