Fix key-file unlock link by removing translatable HTML markup#13396
Open
Copilot wants to merge 4 commits into
Open
Fix key-file unlock link by removing translatable HTML markup#13396Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
1 task
Copilot
AI
changed the title
[WIP] Fix option 'I have a key file' not functioning
Fix key-file unlock link by removing translatable HTML markup
May 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13396 +/- ##
========================================
Coverage 64.46% 64.46%
========================================
Files 378 378
Lines 39795 39797 +2
========================================
+ Hits 25650 25652 +2
Misses 14145 14145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
droidmonkey
approved these changes
Jun 1, 2026
Member
|
Tested and works great |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the unlock dialog’s key-file link by moving clickable HTML anchor markup out of the translator-facing UI string and applying it in code instead.
Changes:
- Replaces the
.uilabel text with plain translatable text. - Wraps the translated label text in a runtime-generated HTML anchor with escaping.
- Updates the English translation catalog entry for the new plain source string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/gui/DatabaseOpenWidget.ui |
Changes the key-file link label source text to plain text. |
src/gui/DatabaseOpenWidget.cpp |
Applies stable anchor markup around the translated label text at runtime. |
share/translations/keepassxc_en.ts |
Updates the English translation source entry for the changed label text. |
Co-authored-by: droidmonkey <2809491+droidmonkey@users.noreply.github.com>
bca93a2 to
a629173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2.7.11, the “I have a key file” action in the unlock dialog could become non-functional in some translations because the translatable string embedded HTML anchor markup. This made link activation dependent on translated HTML structure instead of stable UI code.
Root cause correction: move markup out of translations
DatabaseOpenWidget.uinow stores plain text (I have a key file) instead of an HTML<a>string.Behavior preservation in code
DatabaseOpenWidget.cppnow wraps the translated plain text in anchor markup at runtime, keeping the label clickable and preservinglinkActivated -> browseKeyFile.Security/robustness detail