fix: no workflows found for execution from alert or incident (#4858)

Author: Kiryous

keep-ui/components/ui/Modal.tsx

@@ -1,5 +1,12 @@
 import React from "react";
-import { DialogPanel, Dialog, Text, Badge, Button } from "@tremor/react";
+import {
+  DialogPanel,
+  Dialog,
+  Text,
+  Badge,
+  Button,
+  DialogProps,
+} from "@tremor/react";
 import { XMarkIcon } from "@heroicons/react/24/outline";
 import { PageTitle } from "@/shared/ui/PageTitle";
 
@@ -12,6 +19,7 @@ export default function Modal({
   className = "",
   beta = false,
   description,
+  ...props
 }: {
   children: React.ReactNode;
   isOpen: boolean;
@@ -21,9 +29,9 @@ export default function Modal({
   className?: string;
   beta?: boolean;
   description?: string;
-}) {
+} & Omit<DialogProps, "open" | "onClose" | "static" | "children">) {
   return (
-    <Dialog open={isOpen} onClose={onClose}>
+    <Dialog open={isOpen} onClose={onClose} {...props}>
       <DialogPanel
         className={`flex flex-col border-2 border-orange-300 rounded-lg ring-0 ${className}`}
       >
@@ -54,9 +62,7 @@ export default function Modal({
             )}
           </header>
         )}
-        <div className="flex flex-col flex-1 min-h-0 overflow-auto">
-          {children}
-        </div>
+        <div className="flex flex-col flex-1 min-h-0">{children}</div>
       </DialogPanel>
     </Dialog>
   );

keep-ui/features/workflows/manual-run-workflow/ui/manual-run-workflow-modal.tsx

@@ -9,7 +9,7 @@ import { useApi } from "@/shared/lib/hooks/useApi";
 import { showErrorToast, showSuccessToast } from "@/shared/ui";
 import { Select } from "@/shared/ui";
 import { Trigger, Workflow } from "@/shared/api/workflows";
-import { components, OptionProps } from "react-select";
+import { components, ControlProps, OptionProps } from "react-select";
 import { FilterOptionOption } from "react-select/dist/declarations/src/filters";
 import { WorkflowTriggerBadge } from "@/entities/workflows/ui/WorkflowTriggerBadge";
 import Link from "next/link";
@@ -51,7 +51,8 @@ export function ManualRunWorkflowModal({
   const { workflows } = useWorkflowsV2({
     ...DEFAULT_WORKFLOWS_QUERY,
     limit: 100, // Fetch more workflows at once for the dropdown
-    cel: "disabled == false", // Only show enabled workflows
+    // FIXME: this is a temporary solution until 'disabled == false' query is fixed
+    cel: "(disabled in ['0']) || (disabled == false)", // Only show enabled workflows
   });
   const filteredWorkflows = workflows?.filter((w) => w.canRun);
   const api = useApi();
@@ -196,6 +197,20 @@ export function ManualRunWorkflowModal({
     );
   };
 
+  const CustomControl = (props: ControlProps<Workflow>) => {
+    return (
+      <components.Control
+        {...props}
+        innerProps={
+          {
+            "data-testid": "manual-run-workflow-select-control",
+            ...props.innerProps,
+          } as unknown as React.HTMLAttributes<HTMLDivElement>
+        }
+      />
+    );
+  };
+
   return (
     <Modal
       onClose={clearAndClose}
@@ -206,6 +221,7 @@ export function ManualRunWorkflowModal({
         (effectiveWorkflow?.name ? `Run: ${effectiveWorkflow.name}` : undefined)
       }
       title={workflow ? "Run Workflow with Inputs" : "Run Workflow"}
+      data-testid="manual-run-workflow-modal"
     >
       {/* Only show workflow selector when no workflow is directly provided */}
       {!workflow && (
@@ -249,6 +265,7 @@ export function ManualRunWorkflowModal({
                 }}
                 components={{
                   Option: CustomOption,
+                  Control: CustomControl,
                 }}
                 options={filteredWorkflows}
               />

keep-ui/widgets/alerts-table/ui/alert-table-server-side.tsx

@@ -533,7 +533,10 @@ export function AlertTableServerSide({
       }
     }
     return (
-      <Table className="[&>table]:table-fixed [&>table]:w-full">
+      <Table
+        className="[&>table]:table-fixed [&>table]:w-full"
+        data-testid="alerts-table"
+      >
         <AlertsTableHeaders
           columns={columns}
           table={table}

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "keep"
-version = "0.44.2"
+version = "0.44.3"
 description = "Alerting. for developers, by developers."
 authors = ["Keep Alerting LTD"]
 packages = [{include = "keep"}]

tests/e2e_tests/test_end_to_end.py

@@ -27,7 +27,11 @@
 from datetime import datetime
 
 from playwright.sync_api import Page, expect
+import pytest
 
+from tests.e2e_tests.incidents_alerts_tests.incidents_alerts_setup import (
+    setup_incidents_alerts,
+)
 from tests.e2e_tests.utils import (
     assert_connected_provider_count,
     assert_scope_text_count,
@@ -725,3 +729,66 @@ def test_workflow_unsaved_changes(browser: Page):
     except Exception:
         save_failure_artifacts(page, log_entries)
         raise
+
+
+@pytest.fixture(scope="module")
+def setup_alerts_and_incidents():
+    print("Setting up alerts and incidents...")
+    test_data = setup_incidents_alerts()
+    yield test_data
+
+
+def test_run_workflow_from_alert_and_incident(
+    browser: Page, setup_alerts_and_incidents
+):
+    page = browser
+    log_entries = []
+    setup_console_listener(browser, log_entries)
+    try:
+        init_e2e_test(browser, next_url="/signin")
+        page.goto("http://localhost:3000/workflows")
+        page.get_by_role("button", name="Upload Workflows").click()
+        file_input = page.locator("#workflowFile")
+        file_input.set_input_files(
+            [
+                "./tests/e2e_tests/workflow-alert-log.yaml",
+                "./tests/e2e_tests/workflow-incident-log.yaml",
+            ]
+        )
+        page.get_by_role("button", name="Upload")
+        expect(page.get_by_text("2 workflows uploaded successfully")).to_be_visible()
+        # Run workflow from incident
+        page.goto("http://localhost:3000/incidents")
+        # wait for the incidents facets to load, so it doesn't interfere with the dropdown
+        page.wait_for_selector("[data-testid='facet-value']")
+        page.wait_for_timeout(500)
+        page.get_by_test_id("incidents-table").get_by_test_id(
+            "dropdown-menu-button"
+        ).first.click()
+        page.get_by_test_id("dropdown-menu-list").get_by_role(
+            "button", name="Run workflow"
+        ).click()
+        modal = page.get_by_test_id("manual-run-workflow-modal")
+        modal.get_by_test_id("manual-run-workflow-select-control").click()
+        modal.get_by_role("option", name=re.compile(r"Log every incident")).click()
+        modal.get_by_role("button", name="Run").click()
+        expect(page.get_by_text("Workflow started successfully")).to_be_visible()
+        # Run workflow from alert
+        page.goto("http://localhost:3000/alerts/feed")
+        # wait for the alerts facets to load, so it doesn't interfere with the dropdown
+        page.wait_for_selector("[data-testid='facet-value']")
+        page.wait_for_timeout(500)
+        page.get_by_test_id("alerts-table").locator(
+            "[data-column-id='alertMenu']"
+        ).first.get_by_test_id("dropdown-menu-button").click()
+        page.get_by_test_id("dropdown-menu-list").get_by_role(
+            "button", name="Run workflow"
+        ).click()
+        modal = page.get_by_test_id("manual-run-workflow-modal")
+        modal.get_by_test_id("manual-run-workflow-select-control").click()
+        modal.get_by_role("option", name=re.compile(r"Log every alert")).click()
+        modal.get_by_role("button", name="Run").click()
+        expect(page.get_by_text("Workflow started successfully")).to_be_visible()
+    except Exception:
+        save_failure_artifacts(page, log_entries)
+        raise

tests/e2e_tests/workflow-alert-log.yaml

@@ -0,0 +1,13 @@
+workflow:
+  id: log-every-alert
+  name: Log every alert
+  description: Simple workflow demonstrating logging every alert
+  triggers:
+    - type: manual
+    - type: alert
+  actions:
+    - name: log-alert
+      provider:
+        type: console
+        with:
+          message: "Alert name: {{alert.name}} - {{alert.message}}"

tests/e2e_tests/workflow-incident-log.yaml

@@ -0,0 +1,15 @@
+workflow:
+  id: log-every-incident
+  name: Log every incident
+  description: Simple workflow demonstrating logging every incident
+  triggers:
+    - type: manual
+    - type: incident
+      events:
+        - created
+  actions:
+    - name: log-incident
+      provider:
+        type: console
+        with:
+          message: "Incident name: {{incident.user_generated_name}} - {{incident.severity}}"