Skip to content

feat: Introduce cel ast rebuilder #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 85 commits into
base: main
Choose a base branch
from
Draft

feat: Introduce cel ast rebuilder #4621

wants to merge 85 commits into from

Conversation

skynetigor
Copy link
Contributor

Closes #4573

📑 Description

  • Make fields accessing index-friendly during CEL-to-SQL

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

skynetigor added 30 commits April 23, 2025 16:34
@skynetigor
fix: Refactor NULL behavior with IN operator in CEL
d45f1dc
@skynetigor
fix: Update NULL handling in SQL test cases for consistency
02bf401
@skynetigor
fix: Handle None comparison in SQL equality checks
060bdd7
@skynetigor
fix: Update NULL handling in CEL to SQL test cases for IN operator
d8dfe14
@skynetigor
fix: Simplify NULL handling in SQL test cases and expressions
cc4bce5
@skynetigor
fixes
7df9a04
@skynetigor
fix: Update NULL handling in SQL provider to use "NULL" string for co…
107554d 
…mparisons
@skynetigor
fix mistake in properties metada providing to get_facet_options
b55dac3
@skynetigor
Revert "fix mistake in properties metada providing to get_facet_options"
c59a1c4 
This reverts commit b55dac3.
@skynetigor
fix: Bump version to 0.41.30 in pyproject.toml
145068b
@skynetigor
Merge branch 'main' into 4573-cant-query-incident-field-of-alerts
3181121
@skynetigor
add debugging tips
9c2dcec
@skynetigor
introduce CelAstRebuilder
a524b87
@skynetigor
fix: Improve string representation
39397a2
@skynetigor
refactor: Rename and enhance AST visitor methods for improved clarity…
8f215fa 
… and functionality
@skynetigor
add converting ConstantNode value based on data type of PropertyAcces…
76ffbb1 
…sNode
@skynetigor
Add dialect-specific conversions
4a0b0ed
@skynetigor
Make incident.id and id (alert id) be UUID for correct handling durin…
17fd296 
…g CEL to SQL
@skynetigor
Make incident id in incidents query be UUID
e3246fb
@skynetigor
fix bug during data type extraction
68b6ab3
@skynetigor
Add data_type property for MultipleFieldsNode
b2d4c59
@skynetigor
Add test cases for UUID conversion
a42a27c
@skynetigor
Remove unused import of Any from sqlite.py
2020ea0
@skynetigor
Rename property_path from 'source' to 'providerType' in FacetDto
31a0543
@skynetigor
Add mapping for 'source' to 'alert.provider_type' in FieldMappingConf…
40a0024 
…iguration
@skynetigor
Swap 'providerId' and 'source' mappings in FieldMappingConfiguration …
6d8e0cc 
…for alert provider type consistency
@skynetigor
Rename property_path from 'providerType' to 'source' in FacetDto for …
8fab9fe 
…consistency
@skynetigor
Merge branch '4432-Incident-field-cant-be-queried' into 4573-introduc…
3a88e3e 
…e-cel-ast-rebuilder
@skynetigor
Refactor unary node handling and improve multiple fields processing i…
432ae17 
…n CelAstRebuilder
@skynetigor
Enhance multiple fields node handling by adding is_first and is_last …
d792977 
…parameters to visit comparison node
skynetigor and others added 30 commits May 3, 2025 13:47
@skynetigor
feat: implement conversion from CelAst to QueryBuilder AST
11865fb
@skynetigor
fix incorrect value for ComparisonNodeOperator.NE enum
21a36e3
@skynetigor
Add unit tests for convertCelAstToQueryBuilderAst function
818cf03
@skynetigor
refactor: remove unused FormattedQueryCell component and clean up imp…
c6b28c3 
…orts in CorrelationTable
@skynetigor
refactor: remove unused MethodAccessNode import from cel_ast_converte…
8151e9c 
…r and test files
@skynetigor
refactor: update PropertyAccessNode assertions to use path attribute
508641a
@skynetigor
Merge branch 'main' into 4662-labels-namespace-filtering-in-rules
e74b651
@skynetigor
refactor: simplify query builder logic by extracting node visit funct…
e5936b8 
…ions
@skynetigor
refactor: define node_type attribute directly in AST node classes and…
81838df 
… remove unused IndexAccessNode
@skynetigor
refactor: replace alertsFound.length with totalAlertsFound in AlertsF…
3fb0aa0 
…oundBadge and related components
@skynetigor
Merge branch '4662-labels-namespace-filtering-in-rules' of https://gi…
092ef24 
…thub.com/keephq/keep into 4662-labels-namespace-filtering-in-rules
@skynetigor
refactor: improve alert fetching and validation logic in CorrelationS…
721f940 
…idebar and MonacoCelEditor
@skynetigor
refactor: enhance operand and comparison node handling in PropertiesM…
ae8bda8 
…apper
@skynetigor
refactor: streamline property access node handling in PropertiesMapper
4e0ddee
@skynetigor
refactor: synchronize editor value with props and enhance comparison …
c0555be 
…node validation in PropertiesMapper
@skynetigor
Merge branch 'main' into 4662-labels-namespace-filtering-in-rules
0e85794
@shahargl
Merge branch 'main' into 4662-labels-namespace-filtering-in-rules
95ed696
@skynetigor
Merge branch '4662-labels-namespace-filtering-in-rules' into 4573-int…
9a85a4d 
…roduce-cel-ast-rebuilder
@skynetigor
refactor: replace MethodAccessNode with operator constants and clean …
19245d1 
…up unused code
@skynetigor
refactor: remove MemberAccessNode and update related references to Pr…
21d8ee4 
…opertyAccessNode
@skynetigor
refactor: update data type references and improve error handling in p…
0411f5e 
…roperties mapper
@skynetigor
fix: update data type for incident ID mapping to use DataType.UUID
3bef83e
@skynetigor
Merge branch '4662-labels-namespace-filtering-in-rules' into 4573-int…
8009ca4 
…roduce-cel-ast-rebuilder
@skynetigor
refactor: update type casting in SQL filter to use from_type_to_data_…
6242a5e 
…type function
@skynetigor
refactor: streamline operand node handling in CelAstRebuilder and upd…
ebf46f7 
…ate SQL cast conditions
@skynetigor
refactor: optimize handling of null comparisons in multiple fields node
e816836
@skynetigor
fix debugging
d796219
@skynetigor
refactor booleans
729b188
@skynetigor
refactor: enhance logical node processing by adding boolean flag for …
ed24b5b 
…side handling
@skynetigor
feat: revert back CoalesceNode for handling coalesce operations in AST
b8bc09a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Can't query incident field of alerts
2 participants
@skynetigor @shahargl