Skip to content

feat: Add Icinga2 Provider to Push Monitoring Alerts from Icinga2 to Keep #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 19, 2025

Conversation

DMMutua
Copy link
Contributor

@DMMutua DMMutua commented May 7, 2025

Closes #3810

📑 Description

Integrated Icinga2 Provider for Keep. Will enable users to receive push-based monitoring alerts directly into Keep from Icinga2.

Note: PR improves on closed [#4604]

  • Handling incoming push alerts via webhooks from Icinga2's event command system
  • Payload parsing supporting both host & service alerts
  • Mapping between Icinga2 states & Keep alert severities/statuses
  • Webhook-first design
  • Follows the BaseProvider API consistent with all other Keep's providers

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

  • Relevant Icinga2 Metadata preservation in Keep alert format
  • Webhook endpoint for Icinga2 event commands; enables push-based alert delivery (no polling)
  • Icinga's Icon Added

/claim #3810

DMMutua added 5 commits April 16, 2025 14:46
- Implements Icinga2 provider with REST API integration
- Adds fetching service alerts support with severity mapping
- Implements alert acknowledgement and removal
- Adds provider scope validation for read/write access
    - Renames provider source files and directory
    - Adds config template for auth & deduplication rules
Copy link

vercel bot commented May 7, 2025

@DMMutua is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Documentation Improvements or additions to documentation Feature A new feature hacktoberfest-accepted Provider Providers related issues labels May 7, 2025
@DMMutua DMMutua mentioned this pull request May 7, 2025
9 tasks
Signed-off-by: Tal <talboren2@gmail.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 10, 2025
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview May 19, 2025 10:24am

talboren
talboren previously approved these changes May 10, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 10, 2025
@Kiryous
Copy link
Contributor

Kiryous commented May 15, 2025

@talboren do you have any insight into the process here?

@DMMutua DMMutua force-pushed the icinga2_provider branch from 51dfaa5 to 13e854f Compare May 15, 2025 12:42
@DMMutua DMMutua requested a review from Matvey-Kuk May 16, 2025 07:56
@talboren talboren enabled auto-merge (squash) May 19, 2025 10:27
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@talboren talboren merged commit d699f9f into keephq:main May 19, 2025
17 of 18 checks passed
Copy link
Contributor

🌈 Fantastic work @DMMutua! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

@DMMutua
Copy link
Contributor Author

DMMutua commented May 20, 2025

@shahargl I would also love to be assigned #2112 if possible. I could raise a PR at the earliest on the same since current work on the issue seems stalled.
cc @talboren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim Documentation Improvements or additions to documentation Feature A new feature hacktoberfest-accepted lgtm This PR has been approved by a maintainer Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: Icinga
5 participants