From a170453a4018070a93cb599dc198213e8aefce85 Mon Sep 17 00:00:00 2001 From: Shreyansh Shah Date: Thu, 23 Feb 2023 19:42:33 +0530 Subject: [PATCH 1/2] fix: do not record tc when in test mode Signed-off-by: Shreyansh Shah --- integrations/express/middleware.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/integrations/express/middleware.ts b/integrations/express/middleware.ts index 9d0eaa4..ad6ca5d 100644 --- a/integrations/express/middleware.ts +++ b/integrations/express/middleware.ts @@ -139,6 +139,9 @@ export function afterMiddleware(keploy: Keploy, req: Request, res: Response) { return; } + if (process.env.KEPLOY_MODE=="test") { + return res + } // req.headers // Since, JSON.stingify trims spaces. Therefore, content-length of request header should be updated req.headers["content-length"] = JSON.stringify( From 7436c5a79ae56dd428695184beb0142cf1fdbc1e Mon Sep 17 00:00:00 2001 From: Shreyansh Shah Date: Thu, 2 Mar 2023 13:04:59 +0530 Subject: [PATCH 2/2] fix: review comments Signed-off-by: Shreyansh Shah --- integrations/express/middleware.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/integrations/express/middleware.ts b/integrations/express/middleware.ts index ad6ca5d..1c67e5f 100644 --- a/integrations/express/middleware.ts +++ b/integrations/express/middleware.ts @@ -4,7 +4,7 @@ import Keploy, { HTTP } from "../../src/keploy"; import { Request, Response, NextFunction } from "express"; import { createExecutionContext, getExecutionContext } from "../../src/context"; import { StrArr } from "../../proto/services/StrArr"; - +import { MODE_TEST } from "../../src/mode"; class ResponseBody { static responseMap = new WeakMap(); @@ -139,7 +139,7 @@ export function afterMiddleware(keploy: Keploy, req: Request, res: Response) { return; } - if (process.env.KEPLOY_MODE=="test") { + if (process.env.KEPLOY_MODE===MODE_TEST) { return res } // req.headers