Skip to content

Conversation

sonali-kumari1
Copy link
Member

This PR updates the VGG model preset keys to align with the official naming convention used in Keras and Kaggle documentation.

Copy link
Contributor

Summary of Changes

Hello @sonali-kumari1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the naming conventions for VGG model preset keys within the PRESET_MAP. By updating these keys to include an _imagenet suffix, the project aligns its internal naming with the official conventions found in Keras and Kaggle documentation, enhancing consistency and making it easier for users to identify and utilize the correct model presets.

Highlights

  • Preset Map Key Renaming: The keys within the PRESET_MAP for VGG models have been updated to align with official naming conventions. For example, vgg11 is now vgg_11_imagenet.
  • Standardization: This change ensures consistency with the naming conventions used in Keras and Kaggle documentation, improving clarity and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the VGG model preset keys to align with the project's snake_case naming convention. The changes in tools/checkpoint_conversion/convert_vgg_checkpoints.py are correct and improve consistency across the codebase. My review includes one point of feedback regarding an outdated example in the documentation that should be updated to reflect these new preset names.

Copy link
Collaborator

@sachinprasadhs sachinprasadhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@sachinprasadhs sachinprasadhs merged commit 6df4820 into keras-team:master Sep 24, 2025
10 of 11 checks passed
@sonali-kumari1 sonali-kumari1 deleted the update-vgg-preset-map branch September 24, 2025 16:29
amitsrivastava78 pushed a commit to amitsrivastava78/keras-hub that referenced this pull request Oct 8, 2025
* Update preset map for VGG model

* Update preset map for VGG model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants