-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Keras <> NNX integration #21252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divyashreepathihalli
wants to merge
65
commits into
keras-team:master
Choose a base branch
from
divyashreepathihalli:nnx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Keras <> NNX integration #21252
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
8e1c008
_valu
divyashreepathihalli 7159709
update variables
divyashreepathihalli e378cfb
add nnx.jit
divyashreepathihalli 8701fc7
revert changes to JaxLayer
divyashreepathihalli b599727
Merge branch 'master' into nnx
divyashreepathihalli 4f7b3b8
format fix
divyashreepathihalli 0234e27
make variables subclass nnx.Variable
divyashreepathihalli b87c4f9
more tweaks
divyashreepathihalli 91b9a73
update init
divyashreepathihalli aee1789
refactor jax Variable class
divyashreepathihalli 141487f
code reformat
divyashreepathihalli 5ccc31e
more cleanup
divyashreepathihalli 4e35416
Merge branch 'keras-team:master' into nnx
divyashreepathihalli dd9c77d
update flax version
divyashreepathihalli 48983c6
update flax version
divyashreepathihalli b22f9ef
fix jax error
divyashreepathihalli 4dbffa6
update Variables implementation
divyashreepathihalli 627e581
fix import
divyashreepathihalli f58ef60
add a test
divyashreepathihalli c2b73b7
needs updates in operation
divyashreepathihalli a662f5e
remove __new__ from JaxLayer
divyashreepathihalli 396f973
update base optimizers
divyashreepathihalli 30e971d
code reformat+ model saving tests
divyashreepathihalli 968d804
add __hash__
divyashreepathihalli b99571a
update variable value updates
divyashreepathihalli ed0bc00
sync value properly
divyashreepathihalli 460e0e2
update flag based routing between nnx and jax
divyashreepathihalli 34f27e9
clean up
divyashreepathihalli 427ff82
fix circular import error
divyashreepathihalli c4ee191
fix is nnx call enabled flag
divyashreepathihalli 44414dc
attemptto fix circular import error
divyashreepathihalli 0953d99
try again
divyashreepathihalli 6d54a7e
fix import error
divyashreepathihalli 64adbaf
reformat# Please enter the commit message for your changes. Lines sta…
divyashreepathihalli 6454800
This has to fix it
divyashreepathihalli 001f112
api gen
divyashreepathihalli 5f26958
remove enable diisable configs -that does not work
divyashreepathihalli 782c653
adrress some comments
divyashreepathihalli 561f70a
update conditional imports
divyashreepathihalli e7caa03
fix tests
divyashreepathihalli 8e3f460
add github workflow for nnx
divyashreepathihalli d70d51c
fix test
divyashreepathihalli 38dbd4b
address comments
divyashreepathihalli 1c60c5e
fix test
divyashreepathihalli 74835fd
address comments
divyashreepathihalli 6f11c0c
fix test
divyashreepathihalli c05166e
fix test -_-
divyashreepathihalli 8582c7e
put the set attr in operation
divyashreepathihalli 9471e4e
Merge branch 'master' into nnx
divyashreepathihalli 297775a
fix jax error
divyashreepathihalli f01cc0d
fix trace error
divyashreepathihalli 6810848
remove installation
divyashreepathihalli dc79329
import fixes
divyashreepathihalli f280dd0
update jax version
divyashreepathihalli 75f9cc8
ugh the jax version issue
divyashreepathihalli 68261d4
update jax version
divyashreepathihalli 1e09246
update installations
divyashreepathihalli 8a142a1
update jax utils
divyashreepathihalli c7b2347
another requirents file fix
divyashreepathihalli 99d4307
fix test
divyashreepathihalli d544a0b
add back flax to req common
divyashreepathihalli 3b8d90b
address review comments
divyashreepathihalli 0e0fcd1
fix tests
divyashreepathihalli bd66ec8
fix tests address more comments
divyashreepathihalli 8637c18
fix tests
divyashreepathihalli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"floatx": "float32", | ||
"epsilon": 1e-07, | ||
"backend": "jax", | ||
"image_data_format": "channels_last", | ||
"nnx_enabled": true | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to do something else in addition (or instead of this?), right now, this does not turn on NNX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, because I am seeing the nnx related error on this test workflow