-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Modified compute_output_shape function to handle broadcasting behavior in layers.Rescaling #21351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ur in layers.Rescaling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21351 +/- ##
==========================================
- Coverage 82.65% 77.09% -5.56%
==========================================
Files 565 565
Lines 54823 54934 +111
Branches 8514 8532 +18
==========================================
- Hits 45315 42354 -2961
- Misses 7414 10544 +3130
+ Partials 2094 2036 -58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The change should be accompanied by a unit test.
Please fix the failing torch test
|
compute_output_shape()
inRescaling
to correctly handle the broadcasting and ensure consistent shapes inmodel.summary()
andmodel.output_shape
.Rescaling
layer docstring with detailed description ofscale
andoffset
parameters.Fixes #21319