Add support for all dict methods to ShardedH5IOStroe.
#21365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21365 +/- ##
==========================================
+ Coverage 82.70% 82.73% +0.03%
==========================================
Files 565 565
Lines 54894 55022 +128
Branches 8517 8551 +34
==========================================
+ Hits 45398 45523 +125
+ Misses 7415 7404 -11
- Partials 2081 2095 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fchollet
reviewed
Jun 9, 2025
| @@ -1202,7 +1209,7 @@ def __init__(self, path_or_io, max_shard_size=5, archive=None, mode="r"): | |||
| self.archive = archive | |||
| self.io_file = None | |||
|
|
|||
| self.max_shard_size = float(max_shard_size) | |||
| self.max_shard_size = float(max_shard_size) * 1024**3 # To bytes. | |||
There was a problem hiding this comment.
Is this a behavior change?
There was a problem hiding this comment.
No. I simplified the size computation by using a unified unit: bytes.
We don't need to add conversion between bytes and gigabytes now.
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
len,keys,items,values,inanddelmay raise erros in sharding mode.This PR adds
self.current_shard_filenamesto address these issues.The original sharding test has been updated to a more rigorous one.
cc @divyashreepathihalli @laxmareddyp