Remove Empty class, which is never used by the empty op.
#21368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `ops.numpy.empty` has no tensor inputs, only static parameters, it cannot be used as part of functional model. `empty` never does the usual `if any_symbolic_tensor ... return Empty(...)(...)` so the `Empty` class is dead code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21368 +/- ##
==========================================
- Coverage 82.70% 82.70% -0.01%
==========================================
Files 565 565
Lines 54894 54888 -6
Branches 8517 8517
==========================================
- Hits 45398 45393 -5
+ Misses 7415 7414 -1
Partials 2081 2081
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ops.numpy.emptyhas no tensor inputs, only static parameters, it cannot be used as part of functional model.emptynever does the usualif any_symbolic_tensor ... return Empty(...)(...)so theEmptyclass is dead code.