Fix a bug impacting serialization order for call methods with mutiple inputs. #806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug impacting serialization order for call methods with mutiple inputs.
This bug made
get_config/from_config
andto_json/from_json
not idempotent for layers that take multiple inputs in theircall
method.When the functional model is constructed and the multiple inputs are passed as positional arguments, the
Node
object has multiplecall_args
in a list.However, by design, serialization only treats the first argument and positional and serializes all the other arguments as keyword arguments. Upon deserialization, the extra arguments are created as keyword arguments. Their order was modified by
tf.nest.flatten
, which sorts dicts by key.This change preserves the order of keyword arguments, regardless of keys.
Fixes #795