llarm-emu reinterpret_cast fix for clang-tidy

Author: kernelwernel

cmake/clang_tidy.cmake

@@ -7,7 +7,7 @@ else()
 endif()
 
 function(configure_clang_tidy TARGET)
-    if(CLANG_TIDY_EXE)
+    if(CLANG_TIDY_EXE AND CMAKE_BUILD_TYPE STREQUAL "Debug")
         set_target_properties(${TARGET} PROPERTIES
             CXX_CLANG_TIDY "${CLANG_TIDY_EXE};--use-color;--extra-arg=-Wno-unknown-warning-option"
         )

llarm-emu/llarm/llarm-emu.hpp

@@ -65,9 +65,10 @@ namespace llarm::emu {
         const std::size_t file_size = static_cast<std::size_t>(file.tellg());
         file.seekg(0);
 
-        std::vector<u8> data;
-        data.reserve(file_size);
-        data.assign(std::istreambuf_iterator<char>(file), std::istreambuf_iterator<char>());
+        std::vector<u8> data(file_size);
+
+        // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)
+        file.read(reinterpret_cast<char*>(data.data()), static_cast<std::streamsize>(file_size));
 
         return data;
     }