Close #612 - [logger-f-slf4j-mdc][logger-f-logback-mdc-monix3] SetMdcAdapterand Monix3MdcAdapter should be compatible with older slf4j and logback

- Downgrade slf4j to 2.0.12
- Downgrade logback to 1.5.0 for MDC adapter
- Downgrade logback-scala-interop to 1.0.0

Author: kevin-lee

build.sbt

@@ -82,9 +82,8 @@ lazy val loggerF = (project in file("."))
     catsJvm,
 //    catsJs,
     slf4jMdcJvm,
-//    slf4jMdcJs,
     logbackMdcMonix3Jvm,
-//    logbackMdcMonix3Js,
+    testLogbackMdcMonix3Jvm,
     testKitJvm,
 //    testKitJs,
     catsEffectJvm,
@@ -255,7 +254,7 @@ lazy val cats    =
 lazy val catsJvm = cats.jvm
 lazy val catsJs  = cats.js
 
-lazy val slf4jMdc    = module(ProjectName("slf4j-mdc"), crossProject(JVMPlatform, JSPlatform))
+lazy val slf4jMdc    = module(ProjectName("slf4j-mdc"), crossProject(JVMPlatform))
   .settings(
     description := "Logger for F[_] - A tool to set MDC's MDCAdapter",
     libraryDependencies ++= Seq(
@@ -271,15 +270,15 @@ lazy val slf4jMdc    = module(ProjectName("slf4j-mdc"), crossProject(JVMPlatform
     core
   )
 lazy val slf4jMdcJvm = slf4jMdc.jvm
-lazy val slf4jMdcJs  = slf4jMdc.js
 
-lazy val logbackMdcMonix3    = module(ProjectName("logback-mdc-monix3"), crossProject(JVMPlatform, JSPlatform))
+lazy val logbackMdcMonix3    = module(ProjectName("logback-mdc-monix3"), crossProject(JVMPlatform))
   .settings(
     description := "Logger for F[_] - logback MDC context map support for Monix 3",
     libraryDependencies ++= Seq(
       libs.logbackClassic,
       libs.logbackScalaInterop,
       libs.monix3Execution,
+      libs.slf4jApi % Test,
       libs.tests.monix,
       libs.tests.effectieMonix3,
     ) ++ libs.tests.hedgehogLibs,
@@ -295,7 +294,31 @@ lazy val logbackMdcMonix3    = module(ProjectName("logback-mdc-monix3"), crossPr
     slf4jLogger % Test,
   )
 lazy val logbackMdcMonix3Jvm = logbackMdcMonix3.jvm
-lazy val logbackMdcMonix3Js  = logbackMdcMonix3.js
+
+lazy val testLogbackMdcMonix3    = testProject(ProjectName("logback-mdc-monix3"), crossProject(JVMPlatform))
+  .settings(
+    description := "Logger for F[_] - testing logback MDC context map support for Monix 3",
+    libraryDependencies ++= Seq(
+      libs.slf4jApiLatest            % Test,
+      libs.logbackClassicLatest      % Test,
+      libs.logbackScalaInteropLatest % Test,
+      libs.monix3Execution           % Test,
+      libs.tests.monix,
+      libs.tests.effectieMonix3,
+    ) ++ libs.tests.hedgehogLibs,
+    libraryDependencies := libraryDependenciesRemoveScala3Incompatible(
+      scalaVersion.value,
+      libraryDependencies.value,
+    ),
+  )
+  .dependsOn(
+    core             % Test,
+    slf4jMdc         % Test,
+    logbackMdcMonix3 % "test->test",
+    monix            % Test,
+    slf4jLogger      % Test,
+  )
+lazy val testLogbackMdcMonix3Jvm = testLogbackMdcMonix3.jvm
 
 lazy val testKit    =
   module(ProjectName("test-kit"), crossProject(JVMPlatform, JSPlatform))
@@ -575,21 +598,28 @@ lazy val props =
 
     final val ExtrasVersion = "0.25.0"
 
-    final val Slf4JVersion   = "2.0.17"
-    final val LogbackVersion = "1.5.17"
+    val Slf4JVersion       = "2.0.12"
+    val Slf4JLatestVersion = "2.0.17"
+
+    val LogbackVersion       = "1.5.0"
+    val LogbackLatestVersion = "1.5.17"
 
     final val Log4sVersion = "1.10.0"
 
     final val Log4JVersion = "2.19.0"
 
-    val LogbackScalaInteropVersion = "1.17.0"
+    val LogbackScalaInteropVersion       = "1.0.0"
+    val LogbackScalaInteropLatestVersion = "1.17.0"
   }
 
 lazy val libs =
   new {
 
-    lazy val slf4jApi: ModuleID       = "org.slf4j"      % "slf4j-api"       % props.Slf4JVersion
-    lazy val logbackClassic: ModuleID = "ch.qos.logback" % "logback-classic" % props.LogbackVersion
+    lazy val slf4jApi: ModuleID       = "org.slf4j" % "slf4j-api" % props.Slf4JVersion
+    lazy val slf4jApiLatest: ModuleID = "org.slf4j" % "slf4j-api" % props.Slf4JLatestVersion
+
+    lazy val logbackClassic: ModuleID       = "ch.qos.logback" % "logback-classic" % props.LogbackVersion
+    lazy val logbackClassicLatest: ModuleID = "ch.qos.logback" % "logback-classic" % props.LogbackLatestVersion
 
     lazy val log4sLib: ModuleID = "org.log4s" %% "log4s" % props.Log4sVersion
 
@@ -612,7 +642,9 @@ lazy val libs =
 
     lazy val effectieMonix: ModuleID = "io.kevinlee" %% "effectie-monix3" % props.EffectieVersion
 
-    lazy val logbackScalaInterop = "io.kevinlee" % "logback-scala-interop" % props.LogbackScalaInteropVersion
+    lazy val logbackScalaInterop       = "io.kevinlee" % "logback-scala-interop" % props.LogbackScalaInteropVersion
+    lazy val logbackScalaInteropLatest =
+      "io.kevinlee" % "logback-scala-interop" % props.LogbackScalaInteropLatestVersion
 
     lazy val tests = new {
 
@@ -670,6 +702,19 @@ def module(projectName: ProjectName, crossProject: CrossProject.Builder): CrossP
 def testProject(projectName: ProjectName, crossProject: CrossProject.Builder): CrossProject = {
   val prefixedName = s"test-${prefixedProjectName(projectName.projectName)}"
   projectCommonSettings(prefixedName, crossProject)
+    .settings(
+      // Disable publishing tasks
+      publish / skip := true,
+      publish := {},
+      publishLocal := {},
+      // Prevent artifact generation for publishing
+      publishArtifact := false,
+      packagedArtifacts := Map.empty,
+      // Disable specific packaging tasks
+      packageBin / publishArtifact := false,
+      packageDoc / publishArtifact := false,
+      packageSrc / publishArtifact := false,
+    )
 }
 
 def projectCommonSettings(projectName: String, crossProject: CrossProject.Builder): CrossProject =

modules/logger-f-logback-mdc-monix3/shared/src/main/scala/loggerf/logger/logback/Monix3MdcAdapter.scala

@@ -62,13 +62,29 @@ trait Monix3MdcAdapterOps {
   def initializeWithLoggerContext(loggerContext: LoggerContext): Monix3MdcAdapter =
     initializeWithMonix3MdcAdapterAndLoggerContext(new Monix3MdcAdapter, loggerContext)
 
+  @SuppressWarnings(Array("org.wartremover.warts.Equals"))
   def initializeWithMonix3MdcAdapterAndLoggerContext(
     monix3MdcAdapter: Monix3MdcAdapter,
     loggerContext: LoggerContext,
   ): Monix3MdcAdapter = {
     val adapter = initialize0(monix3MdcAdapter)
+
     loggerContext.setMDCAdapter(adapter)
-    adapter
+    if (loggerContext.getMDCAdapter == adapter) {
+//      println("[LoggerContext] It's set by setMDCAdapter.")
+      adapter
+    } else {
+//      println(
+//        "[LoggerContext] The old setMDCAdapter doesn't replace `mdcAdapter` if it has already been set, " +
+//          "so it will use reflection to set it in the `mdcAdapter` field."
+//      )
+      val loggerContextClass = classOf[LoggerContext]
+      val field              = loggerContextClass.getDeclaredField("mdcAdapter")
+      field.setAccessible(true)
+      field.set(loggerContext, adapter)
+      field.setAccessible(false)
+      adapter
+    }
   }
 
 }

modules/logger-f-logback-mdc-monix3/shared/src/test/scala/loggerf/logger/logback/Monix3MdcAdapterSpec.scala

@@ -4,8 +4,7 @@ import cats.syntax.all._
 import hedgehog._
 import hedgehog.runner._
 import monix.eval.{Task, TaskLocal}
-import org.slf4j.spi.MDCAdapter
-import org.slf4j.{MDC, SetMdcAdapter}
+import org.slf4j.{LoggerFactory, MDC, SetMdcAdapter}
 
 import java.io.{PrintWriter, StringWriter}
 import java.time.Instant
@@ -16,7 +15,8 @@ import scala.util.control.NonFatal
 /** @author Kevin Lee
   * @since 2023-07-03
   */
-object Monix3MdcAdapterSpec extends Properties {
+trait Monix3MdcAdapterSpecsOnly {
+  import Monix3MdcAdapterSpec._
 
   /*
    * Task.defaultOptions.enableLocalContextPropagation is the same as
@@ -37,12 +37,12 @@ object Monix3MdcAdapterSpec extends Properties {
           .err
           .println(
             s"""Error when initializing Monix3MdcAdapter: ${writer.toString}
-           |""".stripMargin
+               |""".stripMargin
           )
         throw ex // scalafix:ok DisableSyntax.throw
     }
 
-  override def tests: List[Test] = List(
+  def tests: List[Test] = List(
     property("Task - MDC should be able to put and get a value", testPutAndGet),
     property("Task - MDC should be able to put and get multiple values concurrently", testPutAndGetMultiple),
     property(
@@ -59,7 +59,8 @@ object Monix3MdcAdapterSpec extends Properties {
     property("Task - MDC: It should return context map for getCopyOfContextMap", testGetCopyOfContextMap),
     property("Task - MDC: It should return context map for getPropertyMap", testGetPropertyMap),
     property("Task - MDC: It should return context map for getKeys", testGetKeys),
-    property("test SetMdcAdapter", testSetMdcAdapter),
+    property("test SetMdcAdapter for MDC", testSetMdcAdapterForMDC),
+    property("test LoggerContext.setMDCAdapter", testLoggerContextSetMdcAdapter),
   )
 
   def before(): Unit =
@@ -487,7 +488,7 @@ object Monix3MdcAdapterSpec extends Properties {
   @SuppressWarnings(Array("org.wartremover.warts.ToString"))
   private def productToMap[A <: Product](product: A): Map[String, String] = {
     // This doesn't work for Scala 2.12
-//    val fields = product.productElementNames.toVector
+    //    val fields = product.productElementNames.toVector
 
     val fields = product.getClass.getDeclaredFields.map(_.getName)
     val length = product.productArity
@@ -506,7 +507,7 @@ object Monix3MdcAdapterSpec extends Properties {
   }
 
   @SuppressWarnings(Array("org.wartremover.warts.Equals"))
-  def testSetMdcAdapter: Property = for {
+  def testSetMdcAdapterForMDC: Property = for {
     mdcAdapterName1 <- Gen.string(Gen.ascii, Range.linear(5, 5)).log("mdcAdapterName1")
     mdcAdapterName2 <- Gen.string(Gen.ascii, Range.linear(5, 5)).log("mdcAdapterName2")
     mdcAdapterName  <- Gen.constant(mdcAdapterName1 + mdcAdapterName2).log("mdcAdapterName")
@@ -526,8 +527,37 @@ object Monix3MdcAdapterSpec extends Properties {
     )
   }
 
+  @SuppressWarnings(Array("org.wartremover.warts.Equals"))
+  def testLoggerContextSetMdcAdapter: Property = for {
+    mdcAdapterName1 <- Gen.string(Gen.ascii, Range.linear(5, 5)).log("mdcAdapterName1")
+    mdcAdapterName2 <- Gen.string(Gen.ascii, Range.linear(5, 5)).log("mdcAdapterName2")
+    mdcAdapterName  <- Gen.constant(mdcAdapterName1 + mdcAdapterName2).log("mdcAdapterName")
+  } yield {
+    val mdcAdapter    = TestMdcAdapter(mdcAdapterName)
+    @SuppressWarnings(Array("org.wartremover.warts.AsInstanceOf"))
+    val loggerContext =
+      LoggerFactory
+        .getILoggerFactory
+        .asInstanceOf[ch.qos.logback.classic.LoggerContext] // scalafix:ok DisableSyntax.asInstanceOf
+
+    val before = loggerContext.getMDCAdapter()
+
+    val _ = Monix3MdcAdapter.initializeWithMonix3MdcAdapterAndLoggerContext(mdcAdapter, loggerContext)
+
+    val after = loggerContext.getMDCAdapter()
+
+    Result.all(
+      List(
+        Result.diffNamed("before should not be equal to the new MDCAdapter", before, mdcAdapter)(_ != _),
+        (after ==== mdcAdapter).log("after SetMdcAdapter should be equal to the new MDCAdapter"),
+      )
+    )
+  }
+}
+object Monix3MdcAdapterSpec extends Properties with Monix3MdcAdapterSpecsOnly {
+
   @SuppressWarnings(Array("org.wartremover.warts.Var"))
-  final case class TestMdcAdapter(name: String) extends MDCAdapter {
+  final case class TestMdcAdapter(name: String) extends Monix3MdcAdapter {
 
     override def put(key: String, `val`: String): Unit = ???
 
@@ -539,7 +569,7 @@ object Monix3MdcAdapterSpec extends Properties {
 
     override def getCopyOfContextMap: util.Map[String, String] = ???
 
-    override def setContextMap(contextMap: util.Map[String, String]): Unit = ???
+    override def setContextMap0(contextMap: util.Map[String, String]): Unit = ???
 
     override def pushByKey(key: String, value: String): Unit = ???
 

modules/logger-f-slf4j-mdc/shared/src/main/scala/org/slf4j/SetMdcAdapter.scala

@@ -2,6 +2,8 @@ package org.slf4j
 
 import org.slf4j.spi.MDCAdapter
 
+import scala.util.control.NonFatal
+
 /** @author Kevin Lee
   * @since 2025-03-09
   */
@@ -10,7 +12,23 @@ trait SetMdcAdapter {
 }
 
 object SetMdcAdapter {
+  @SuppressWarnings(Array("org.wartremover.warts.Null"))
   def apply(mdcAdapter: MDCAdapter): Unit = {
-    MDC.setMDCAdapter(mdcAdapter)
+    val mdcClass = classOf[MDC]
+    try {
+      val method = mdcClass.getDeclaredMethod("setMDCAdapter", classOf[MDCAdapter])
+      val _      = method.invoke(null, mdcAdapter) // scalafix:ok DisableSyntax.null
+//      println("[MDC] A method named `setMDCAdapter` was found, so it was set using `setMDCAdapter` with reflection.")
+      ()
+    } catch {
+      case NonFatal(_) =>
+//        println(
+//          "[MDC] No method named `setMDCAdapter` was found, so it will instead be set to the `mdcAdapter` field using reflection."
+//        )
+        val field = mdcClass.getDeclaredField("mdcAdapter")
+        field.setAccessible(true)
+        field.set(null, mdcAdapter) // scalafix:ok DisableSyntax.null
+        field.setAccessible(false)
+    }
   }
 }

modules/test-logger-f-logback-mdc-monix3/shared/src/test/scala/loggerf/logger/logback/Monix3MdcAdapterForLogback1_5_17_PlusAndSlf4j2_0_17Spec.scala

@@ -0,0 +1,8 @@
+package loggerf.logger.logback
+
+import hedgehog.runner._
+
+/** @author Kevin Lee
+  * @since 2025-03-11
+  */
+object Monix3MdcAdapterForLogback1_5_17_PlusAndSlf4j2_0_17Spec extends Properties with Monix3MdcAdapterSpecsOnly