[progress-bar] Add separated option + deprecations#240
Merged
Conversation
b3ae24b to
9230992
Compare
kevinpapst
reviewed
Dec 16, 2025
kevinpapst
reviewed
Dec 16, 2025
kevinpapst
reviewed
Dec 16, 2025
kevinpapst
reviewed
Dec 16, 2025
kevinpapst
reviewed
Dec 16, 2025
kevinpapst
reviewed
Dec 17, 2025
kevinpapst
requested changes
Dec 17, 2025
Owner
kevinpapst
left a comment
There was a problem hiding this comment.
Can you please check my comments
kevinpapst
previously approved these changes
Dec 18, 2025
# Conflicts: # UPGRADING.md
kevinpapst
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress background
Usage
{{ progress_background({width : 65, text: 'Poland'}) }} {{ progress_background({width : 35, text: 'Germany'}) }} {{ progress_background({width : 28, text: 'United Stated'}) }} {{ progress_background({width : 20, text: 'United Kingdom'}) }} {{ progress_background({width : 15, text: 'France'}) }}Progress bar
Deprecated
currentdeprecated, replaced byvaluecolorshould not be "bootstrap classes" value, but it's color directly. eg:red,blue, ...backgroundColorprogressSize{{ progress_bar() }} {{ progress_bar({current : 1}) }} {{ progress_bar({current : 2, max : 3, min : -1}) }} {{ progress_bar({current : 2, max : 3}) }} {{ progress_bar({current : 2, max : 3, color : 'bg-red'}, {backgroundColor : 'bg-grey'}) }} {{ progress_bar({current : 2, max : 3, color : 'bg-green'}, {progressSize : 'progress-sm'}) }} {{ progress_bar({current : 2, max : 3, color : 'bg-orange'}, {style : 'height: 20px;'}) }} {{ progress_bar({color : 'bg-red'}, {backgroundColor : 'bg-grey'}) }} {{ progress_bar({current :2, max: 5, color : 'bg-red', striped : true}) }} {{ progress_bar({current :2, max: 5, striped : true, animated: true}) }}Expected
{{ progress_bar() }} {{ progress_bar({current : 10}) }} {{ progress_bar({current : 66, max : 100}) }} {{ progress_bar({current : 40, max : 50, min : -50}) }} {{ progress_bar({current : 66, max : 100, color : 'success'}, {extraClass : 'bg-danger'}) }} {{ progress_bar({current : 66, max : 100, color : 'orange'}, {height: '4px'}) }} {{ progress_bar({current : 66, max : 100, autoLabel : true}) }} {{ progress_bar({current : 66, max : 100, label : 'Partially done'}, {height: '20px'}) }} {{ progress_bar({current : 66, max : 100, label : 'Error while processing', color : 'danger'}, {height: '20px'}) }} {{ progress_bar({color : 'green'}, {extraClass : 'bg-green-lt'}) }} {{ progress_bar({current :2, max: 5, color : 'red', striped : true}) }} {{ progress_bar({current :4, max: 5, striped : true, animated: true}) }}Types of changes
Checklist