Skip to content

[progress-bar] Add separated option + deprecations#240

Merged
kevinpapst merged 10 commits into
mainfrom
progress-bar
Dec 18, 2025
Merged

[progress-bar] Add separated option + deprecations#240
kevinpapst merged 10 commits into
mainfrom
progress-bar

Conversation

@cavasinf
Copy link
Copy Markdown
Collaborator

@cavasinf cavasinf commented Dec 15, 2025

Progress background

image

Usage

{{ progress_background({width : 65, text: 'Poland'}) }}
{{ progress_background({width : 35, text: 'Germany'}) }}
{{ progress_background({width : 28, text: 'United Stated'}) }}
{{ progress_background({width : 20, text: 'United Kingdom'}) }}
{{ progress_background({width : 15, text: 'France'}) }}

Progress bar

image

Deprecated

  • Item value current deprecated, replaced by value
  • Item value color should not be "bootstrap classes" value, but it's color directly. eg: red, blue, ...
  • Removed the options backgroundColor
  • Removed the options progressSize
{{ progress_bar() }}

{{ progress_bar({current : 1}) }}

{{ progress_bar({current : 2, max : 3, min : -1}) }}

{{ progress_bar({current : 2, max : 3}) }}

{{ progress_bar({current : 2, max : 3, color : 'bg-red'}, {backgroundColor : 'bg-grey'}) }}

{{ progress_bar({current : 2, max : 3, color : 'bg-green'}, {progressSize : 'progress-sm'}) }}

{{ progress_bar({current : 2, max : 3, color : 'bg-orange'}, {style : 'height: 20px;'}) }}

{{ progress_bar({color : 'bg-red'}, {backgroundColor : 'bg-grey'}) }}

{{ progress_bar({current :2, max: 5, color : 'bg-red', striped : true}) }}

{{ progress_bar({current :2, max: 5, striped : true, animated: true}) }}

Expected

{{ progress_bar() }}

{{ progress_bar({current : 10}) }}

{{ progress_bar({current : 66, max : 100}) }}

{{ progress_bar({current : 40, max : 50, min : -50}) }}

{{ progress_bar({current : 66, max : 100, color : 'success'}, {extraClass : 'bg-danger'}) }}

{{ progress_bar({current : 66, max : 100, color : 'orange'}, {height: '4px'}) }}

{{ progress_bar({current : 66, max : 100, autoLabel : true}) }}

{{ progress_bar({current : 66, max : 100, label : 'Partially done'}, {height: '20px'}) }}

{{ progress_bar({current : 66, max : 100, label : 'Error while processing', color : 'danger'}, {height: '20px'}) }}

{{ progress_bar({color : 'green'}, {extraClass : 'bg-green-lt'}) }}

{{ progress_bar({current :2, max: 5, color : 'red', striped : true}) }}

{{ progress_bar({current :4, max: 5, striped : true, animated: true}) }}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf added this to the 2.0 milestone Dec 15, 2025
@cavasinf cavasinf self-assigned this Dec 15, 2025
@cavasinf cavasinf added Feature Feature requested BC Break This will cause BC Break labels Dec 15, 2025
@cavasinf cavasinf marked this pull request as ready for review December 15, 2025 15:55
@cavasinf cavasinf requested a review from kevinpapst December 16, 2025 08:02
Comment thread UPGRADING.md Outdated
Comment thread UPGRADING.md Outdated
Comment thread templates/components/progress_bar.html.twig Outdated
Comment thread templates/components/progress_bar.html.twig Outdated
Comment thread templates/components/progress_bar.html.twig Outdated
Comment thread docs/components-progress-bar.md Outdated
Copy link
Copy Markdown
Owner

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check my comments

kevinpapst
kevinpapst previously approved these changes Dec 18, 2025
# Conflicts:
#	UPGRADING.md
@kevinpapst kevinpapst merged commit aed5167 into main Dec 18, 2025
5 checks passed
@kevinpapst kevinpapst deleted the progress-bar branch December 18, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC Break This will cause BC Break Feature Feature requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants