Skip to content

Upgrade the docker image to the latest #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robertoperuzzo opened this issue Apr 9, 2025 · 2 comments
Open

Upgrade the docker image to the latest #5

robertoperuzzo opened this issue Apr 9, 2025 · 2 comments

Comments

@robertoperuzzo
Copy link

robertoperuzzo commented Apr 9, 2025 •
edited
Loading

Upgrade the Typesense Docker image from 0.25.1 to 28.0.

Looking at Typesense documentation we have to use this snippet

services:
  typesense:
    image: typesense/typesense:28.0
robertoperuzzo added a commit to robertoperuzzo/ddev-typesense that referenced this issue Apr 9, 2025
@robertoperuzzo
refs kevinquillen#5: Upgrades the docker image to 0.28.0
61e9ca2
robertoperuzzo added a commit to robertoperuzzo/ddev-typesense that referenced this issue Apr 9, 2025
@robertoperuzzo
refs kevinquillen#5: Upgrades the docker image to 28.0
da1ea45
robertoperuzzo added a commit to robertoperuzzo/ddev-typesense that referenced this issue Apr 9, 2025
@robertoperuzzo
refs kevinquillen#5: Fixes the docker compose settings
816cf4a
robertoperuzzo added a commit to robertoperuzzo/ddev-typesense that referenced this issue Apr 9, 2025
@robertoperuzzo
refs kevinquillen#5: Fixes the docker compose settings
3b4a047
@kevinquillen
Copy link
Owner

kevinquillen commented Apr 19, 2025 •
edited
Loading

Thanks for the change - but there are more changes in the commit than just the Typesense image. Was that intended?

In particular, the restart value was changed from on-failure/always due to the explanation and PR opened here for Meilisearch: kevinquillen/ddev-meilisearch#7

@robertoperuzzo
Copy link
Author

In my first try, I changed only the image version, but the add-on does not run the container correct, so I decided to use this docker-compose.typesense.yaml and it works.

Regarding the restart value, no problem, I can change it as discussed in kevinquillen/ddev-meilisearch#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinquillen @robertoperuzzo