refactor(core)!: migrate to custom DnD engine and update patching logic

- Remove `sortablejs` dependency and implement custom drag-and-drop engine in `dnd-manager.ts`
- Update patching logic to intercept `getSortedFolderItems` method and sort items in custom order
- Don't save `customOrder` changes to `data.json` on file create/delete to avoid sync conflicts (only save on drag-and-drop)
- Replace drag animation with Spotify-like drop indicator
- Move managers to separate `managers/` folder with barrel exports
- Add `infoCompact` method to `Logger` for convenient large object output
- Simplify `ResetOrderModal` message
- Simplify `SettingsTab` description
- Add removal of third-party properties from settings file in `loadSettings`
- Add barrel file exports in `utils` folder
- Disable `@typescript-eslint/no-non-null-assertion` rule in ESLint config

BREAKING CHANGES:
- Changed settings storage format: renamed `customFileOrder` to `customOrder`, `selectedSortOrder` to `sortOrder`, and `newItemsPosition` to `newItemPlacement`
- Removed `draggingEnabled` option

Fixes #34, #46, #48, #49, #73

Author: kh4f

eslint.config.ts

@@ -24,6 +24,7 @@ export default defineConfig([
 			'@typescript-eslint/no-confusing-void-expression': ['error', { ignoreArrowShorthand: true }],
 			'@typescript-eslint/no-this-alias': 'off',
 			'@typescript-eslint/prefer-nullish-coalescing': 'off',
+			'@typescript-eslint/no-non-null-assertion': 'off',
 			'@typescript-eslint/naming-convention': ['error', {
 				selector: ['classProperty', 'classMethod'],
 				format: ['camelCase'],

package.json

@@ -57,8 +57,7 @@
 		"vitest": "^4.0.6"
 	},
 	"dependencies": {
-		"monkey-around": "^3.0.0",
-		"sortablejs": "^1.15.6"
+		"monkey-around": "^3.0.0"
 	},
 	"simple-git-hooks": {
 		"pre-commit": "pnpm lint-staged"

pnpm-lock.yaml

@@ -1,13 +1,13 @@
 import { App, ButtonComponent, Modal } from 'obsidian'
 
 export class ResetOrderModal extends Modal {
-	constructor(app: App, prevSelectedSortOrder: string, onSubmit: () => void) {
+	constructor(app: App, onSubmit: () => void) {
 		super(app)
 		this.setTitle('Manual sorting')
 		this.modalEl.addClass('manual-sorting-modal')
 
 		const modalContent = this.contentEl.createEl('div')
-		modalContent.createEl('p', { text: `Reset custom order to match previously selected one (${prevSelectedSortOrder})?` })
+		modalContent.createEl('p', { text: `Reset custom order?` })
 		const modalButtons = modalContent.createEl('div', { cls: 'modal-buttons' })
 		new ButtonComponent(modalButtons)
 			.setButtonText('Yep')

src/components/reset-order-modal.ts

@@ -1,6 +1,6 @@
 import { App, PluginSettingTab, Setting } from 'obsidian'
 import type ManualSortingPlugin from '@/plugin'
-import { Logger } from '@/utils/logger'
+import { Logger } from '@/utils'
 
 export class SettingsTab extends PluginSettingTab {
 	constructor(app: App, public plugin: ManualSortingPlugin) {
@@ -11,14 +11,14 @@ export class SettingsTab extends PluginSettingTab {
 		this.containerEl.empty()
 
 		new Setting(this.containerEl)
-			.setName('New items position')
-			.setDesc('Position of newly created items in a folder.')
+			.setName('New item placement')
+			.setDesc('Default new item placement.')
 			.addDropdown(dropdown => dropdown
 				.addOption('top', 'Top')
 				.addOption('bottom', 'Bottom')
-				.setValue(this.plugin.settings.newItemsPosition)
+				.setValue(this.plugin.settings.newItemPlacement)
 				.onChange(async value => {
-					this.plugin.settings.newItemsPosition = value as 'top' | 'bottom'
+					this.plugin.settings.newItemPlacement = value as 'top' | 'bottom'
 					await this.plugin.saveSettings()
 				}),
 			)

src/components/settings-tab.ts

@@ -1,16 +1,12 @@
 import { type PluginSettings } from '@/types.d'
 
-export const MANUAL_SORTING_MODE_ID = 'manual-sorting'
+export const CUSTOM_SORTING_ID = 'customOrder'
 
-export const DND_MIN_SWAP_THRESHOLD = 0.3
-export const DND_MAX_SWAP_THRESHOLD = 2
-
-export const FILE_EXPLORER_SELECTOR = '[data-type="file-explorer"] .nav-files-container'
+export const FILE_EXPLORER_SELECTOR = '[data-type="file-explorer"] > .nav-files-container > div'
 
 export const DEFAULT_SETTINGS: PluginSettings = {
-	customFileOrder: { '/': [] },
-	draggingEnabled: true,
-	selectedSortOrder: 'manual-sorting',
+	customOrder: { '/': [] },
+	sortOrder: 'customOrder',
 	debugMode: !!process.env.DEV,
-	newItemsPosition: 'top',
+	newItemPlacement: 'top',
 }