test(retrofit2): add test to verify retrofit2 error handling

Author: kirangodishala

clouddriver-core/clouddriver-core.gradle

@@ -63,4 +63,5 @@ dependencies {
   testImplementation "com.google.cloud:google-cloud-secretmanager"
   testImplementation "io.spinnaker.kork:kork-cloud-config-server"
   testImplementation "com.squareup.retrofit2:retrofit-mock"
+  testImplementation "com.github.tomakehurst:wiremock-jre8-standalone"
 }

clouddriver-core/src/main/java/com/netflix/spinnaker/clouddriver/config/RetrofitConfig.java

@@ -30,7 +30,7 @@
 
 @Configuration
 @EnableConfigurationProperties(Front50ConfigurationProperties.class)
-class RetrofitConfig {
+public class RetrofitConfig {
 
   @Bean
   @ConditionalOnProperty(name = "services.front50.enabled", matchIfMissing = true)

clouddriver-core/src/test/java/com/netflix/spinnaker/clouddriver/safety/TrafficGuardTest.java

@@ -0,0 +1,118 @@
+package com.netflix.spinnaker.clouddriver.safety;
+
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.getRequestedFor;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlMatching;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo;
+import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.wireMockConfig;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.github.tomakehurst.wiremock.client.WireMock;
+import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
+import com.netflix.spectator.api.NoopRegistry;
+import com.netflix.spinnaker.clouddriver.config.RetrofitConfig;
+import com.netflix.spinnaker.clouddriver.core.services.Front50Service;
+import com.netflix.spinnaker.clouddriver.model.NoopClusterProvider;
+import com.netflix.spinnaker.config.DefaultServiceClientProvider;
+import com.netflix.spinnaker.config.okhttp3.DefaultOkHttpClientBuilderProvider;
+import com.netflix.spinnaker.config.okhttp3.OkHttpClientProvider;
+import com.netflix.spinnaker.kork.dynamicconfig.DynamicConfigService;
+import com.netflix.spinnaker.kork.retrofit.Retrofit2ServiceFactory;
+import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerHttpException;
+import com.netflix.spinnaker.moniker.Moniker;
+import com.netflix.spinnaker.okhttp.OkHttpClientConfigurationProperties;
+import com.netflix.spinnaker.okhttp.SpinnakerRequestHeaderInterceptor;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import okhttp3.OkHttpClient;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.http.HttpStatus;
+import org.springframework.test.context.DynamicPropertyRegistry;
+import org.springframework.test.context.DynamicPropertySource;
+
+@SpringBootTest(
+    classes = {
+      RetrofitConfig.class,
+      OkHttpClientProvider.class,
+      TrafficGuardTest.TestConfig.class,
+      DefaultServiceClientProvider.class,
+      Retrofit2ServiceFactory.class,
+      DefaultOkHttpClientBuilderProvider.class,
+      OkHttpClient.class,
+      OkHttpClientConfigurationProperties.class,
+      ObjectMapper.class
+    })
+public class TrafficGuardTest {
+  private final String APP_NAME = "testApp";
+
+  @RegisterExtension
+  static WireMockExtension wmFront50 =
+      WireMockExtension.newInstance().options(wireMockConfig().dynamicPort()).build();
+
+  @Autowired ObjectMapper objectMapper;
+
+  @Autowired Front50Service front50Service;
+
+  @Autowired SpinnakerRequestHeaderInterceptor requestHeaderInterceptor;
+
+  TrafficGuard trafficGuard;
+
+  @DynamicPropertySource
+  static void registerUrls(DynamicPropertyRegistry registry) {
+    // Configure wiremock's random ports into clouddriver
+    System.out.println("wiremock front50 url: " + wmFront50.baseUrl());
+    registry.add("services.front50.base-url", wmFront50::baseUrl);
+  }
+
+  @BeforeEach
+  void init() throws JsonProcessingException {
+    wmFront50.stubFor(
+        WireMock.get(urlMatching("/v2/applications/" + APP_NAME))
+            .willReturn(
+                aResponse()
+                    .withStatus(HttpStatus.INTERNAL_SERVER_ERROR.value())
+                    .withBody(
+                        objectMapper.writeValueAsString(
+                            Map.of("error", "Internal Server Error")))));
+
+    trafficGuard =
+        new TrafficGuard(
+            List.of(new NoopClusterProvider()),
+            Optional.of(front50Service),
+            new NoopRegistry(),
+            new DynamicConfigService.NoopDynamicConfig());
+  }
+
+  @Test
+  void verifyErrorHandlingCallAdapterFactory_with_500_exception() {
+    Moniker moniker = Moniker.builder().app(APP_NAME).build();
+    Exception ex = null;
+
+    try {
+      trafficGuard.hasDisableLock(moniker, "acc1", "location1");
+    } catch (Exception e) {
+      ex = e;
+    }
+
+    assert ex instanceof SpinnakerHttpException;
+
+    wmFront50.verify(getRequestedFor(urlPathEqualTo("/v2/applications/" + APP_NAME)));
+  }
+
+  @Configuration
+  static class TestConfig {
+
+    @Bean
+    SpinnakerRequestHeaderInterceptor spinnakerRequestHeaderInterceptor() {
+      return new SpinnakerRequestHeaderInterceptor(false);
+    }
+  }
+}