[FIX] match validation bugs

bim-g · web-flow · commit 74339a008a80 · 2023-08-21T09:28:17.000+02:00
the strlen calculation is the reason that match validation has some issue because in case the new string has the same size it will make all the operation true while it's not the case.
diff --git a/src/Validator/StringValidator.php b/src/Validator/StringValidator.php
@@ -105,7 +105,7 @@ public function url()
     public function match(string $key_to_match)
     {
         $this->isStringAndValid($key_to_match);
-        if (isset($this->data_source[$key_to_match]) && (strlen($this->field_value) != strlen($this->data_source[$key_to_match])) && ($this->field_value != $this->data_source[$key_to_match])) {
+        if (isset($this->data_source[$key_to_match]) && ($this->field_value != $this->data_source[$key_to_match])) {
             $this->messageItem
                 ->type('string.match')
                 ->message("`$this->field_name` should match `$key_to_match`")

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public function url()`
`105`	`105`	`public function match(string $key_to_match)`
`106`	`106`	`{`
`107`	`107`	`$this->isStringAndValid($key_to_match);`
`108`		`- if (isset($this->data_source[$key_to_match]) && (strlen($this->field_value) != strlen($this->data_source[$key_to_match])) && ($this->field_value != $this->data_source[$key_to_match])) {`
	`108`	`+ if (isset($this->data_source[$key_to_match]) && ($this->field_value != $this->data_source[$key_to_match])) {`
`109`	`109`	`$this->messageItem`
`110`	`110`	`->type('string.match')`
`111`	`111`	->message("`$this->field_name` should match `$key_to_match`")