WIP: Testplan multi-clone #4001
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems a bit more appropriate
make the button more square-ish which looks better with the rest of the buttons. The fa-code-fork icon is very narrow and doesn't look good. Also update button text to just the action -> "Clone"
will always point to the existing clone URL which will later be modified to handle multiple arguments via query string
makes more sense to alert inside the function instead of delegating this to the caller. This is how selectedCheckboxes() works too and this function is kind of a duplicate almost!
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return false | ||
| } | ||
|
|
||
| window.location.assign(`/plan/0/clone/?p=${selectedTestPlans.join('&p=')}`) |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the issue, we need to sanitize or escape the DOM text before using it in the URL. The escapeHTML utility function, which is already imported in the file, can be used to escape special characters in the extracted text. This ensures that any malicious input is neutralized before being included in the URL. The fix involves applying escapeHTML to the id values returned by getChildRows before they are added to the tpIds array.
Suggested changeset
1
tcms/testplans/static/testplans/js/search.js
| @@ -252,3 +252,3 @@ | ||
| const parentRow = $('#resultsTable').DataTable().row($(parentRowId).closest('tr')) | ||
| const id = $(parentRowId).closest('tr').find('td:nth-child(3)').text().trim() | ||
| const id = escapeHTML($(parentRowId).closest('tr').find('td:nth-child(3)').text().trim()) | ||
| const children = hiddenChildRows[id] |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks some of the initial work in #3985 and refactors it to better fit the existing code style and how we do things in Kiwi TCMS.
First batch of work focuses on the UI first.