Merge branch 'main' into feature/php-8.4-fix-csv-deprecation

Author: swissspidy

features/requests.feature

@@ -1,7 +1,8 @@
 Feature: Requests integration with both v1 and v2
 
   # This test downgrades to WordPress 5.8, but the SQLite plugin requires 6.0+
-  @require-mysql
+  # WP-CLI 2.7 causes deprecation warnings on PHP 8.2
+  @require-mysql @less-than-php-8.2
   Scenario: Composer stack with Requests v1
     Given an empty directory
     And a composer.json file:

php/WP_CLI/Extractor.php

@@ -48,7 +48,7 @@ private static function extract_zip( $zipfile, $dest ) {
 			throw new Exception( "Could not create folder '{$dest}'." );
 		}
 
-		if ( ! file( $zipfile )
+		if ( ! file_exists( $zipfile )
 			|| ! is_readable( $zipfile )
 			|| filesize( $zipfile ) <= 0 ) {
 			throw new Exception( "Invalid zip file '{$zipfile}'." );
@@ -127,7 +127,7 @@ private static function extract_tarball( $tarball, $dest ) {
 			$tarball = "./{$tarball}";
 		}
 
-		if ( ! file( $tarball )
+		if ( ! file_exists( $tarball )
 			|| ! is_readable( $tarball )
 			|| filesize( $tarball ) <= 0 ) {
 			throw new Exception( "Invalid zip file '{$tarball}'." );

tests/CommandFactoryTest.php

@@ -2,10 +2,12 @@
 
 use WP_CLI\Tests\TestCase;
 
-require_once dirname( __DIR__ ) . '/php/class-wp-cli-command.php';
-
 class CommandFactoryTest extends TestCase {
 
+	public static function set_up_before_class() {
+		require_once dirname( __DIR__ ) . '/php/class-wp-cli-command.php';
+	}
+
 	/**
 	 * @dataProvider dataProviderExtractLastDocComment
 	 */

tests/FileCacheTest.php

@@ -5,10 +5,12 @@
 use WP_CLI\Tests\TestCase;
 use WP_CLI\Utils;
 
-require_once dirname( __DIR__ ) . '/php/class-wp-cli.php';
-
 class FileCacheTest extends TestCase {
 
+	public static function set_up_before_class() {
+		require_once dirname( __DIR__ ) . '/php/class-wp-cli.php';
+	}
+
 	/**
 	 * Test get_root() deals with backslashed directory.
 	 */

tests/HelpTest.php

@@ -2,12 +2,14 @@
 
 use WP_CLI\Tests\TestCase;
 
-require_once dirname( __DIR__ ) . '/php/class-wp-cli.php';
-require_once dirname( __DIR__ ) . '/php/class-wp-cli-command.php';
-require_once dirname( __DIR__ ) . '/php/commands/help.php';
-
 class HelpTest extends TestCase {
 
+	public static function set_up_before_class() {
+		require_once dirname( __DIR__ ) . '/php/class-wp-cli.php';
+		require_once dirname( __DIR__ ) . '/php/class-wp-cli-command.php';
+		require_once dirname( __DIR__ ) . '/php/commands/help.php';
+	}
+
 	public function test_parse_reference_links() {
 		$test_class = new ReflectionClass( 'Help_Command' );
 		$method     = $test_class->getMethod( 'parse_reference_links' );

tests/UtilsTest.php

@@ -5,11 +5,13 @@
 use WP_CLI\Tests\TestCase;
 use WP_CLI\Utils;
 
-require_once dirname( __DIR__ ) . '/php/class-wp-cli.php';
-require_once __DIR__ . '/mock-requests-transport.php';
-
 class UtilsTest extends TestCase {
 
+	public static function set_up_before_class() {
+		require_once dirname( __DIR__ ) . '/php/class-wp-cli.php';
+		require_once __DIR__ . '/mock-requests-transport.php';
+	}
+
 	public function testIncrementVersion() {
 		// Keyword increments.
 		$this->assertEquals(

tests/WP_CLI/WpOrgApiTest.php

@@ -3,10 +3,12 @@
 use WP_CLI\Tests\TestCase;
 use WP_CLI\WpOrgApi;
 
-require_once dirname( __DIR__ ) . '/mock-requests-transport.php';
-
 class WpOrgApiTest extends TestCase {
 
+	public static function set_up_before_class() {
+		require_once dirname( __DIR__ ) . '/mock-requests-transport.php';
+	}
+
 	public static function data_http_request_verify() {
 		return [
 			'can retrieve core checksums'              => [