Skip to content

Add limitations for having OIDC and Istio enabled#5940

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
creydr:add-limitations-for-oidc-with-istio
Apr 12, 2024
Merged

Add limitations for having OIDC and Istio enabled#5940
knative-prow[bot] merged 2 commits intoknative:mainfrom
creydr:add-limitations-for-oidc-with-istio

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Apr 10, 2024

Explain limitations for having authentication-oidc enabled and eventing-istio.

@creydr creydr requested a review from pierDipi April 10, 2024 13:44
@knative-prow knative-prow Bot requested a review from csantanapr April 10, 2024 13:45
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e4c1f00
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6617f980c258d90008633832
😎 Deploy Preview https://deploy-preview-5940--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 12, 2024

/cc @pierDipi

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit b820198 into knative:main Apr 12, 2024
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
* Add limitations for having OIDC and Istio enabled

* Fix list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants