Skip to content

Sample App: Fix the content in the bad word filter knative function code #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Apr 23, 2024

Proposed Changes

  • Fixed the input and output cloudevent format

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2024
@knative-prow knative-prow bot requested review from csantanapr and ReToCode April 23, 2024 18:16
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b43846
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/662abda7cbbd2e0007196fb7
😎 Deploy Preview https://deploy-preview-5947--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@Cali0707
Copy link
Member

Hey @Leo6Leo what's the context on this change?

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Apr 25, 2024

@Cali0707 As some of the schema is changed from the time when the original PR get merged, thus making this PR to reflect the new schema change.

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Apr 25, 2024

/cc @pierDipi @Cali0707

This PR should be good to be merged. Further changes will be performed in #5948

@knative-prow knative-prow bot requested review from Cali0707 and pierDipi April 25, 2024 20:32
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link

knative-prow bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 61e322a into knative:main Apr 26, 2024
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
…ode (knative#5947)

* Fix the content in the bad word filter knative function code

* Remove the unused import

* fix: fix the python format by running black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants