Skip to content

Helm: create and use 'knative-operator' namespace #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Helm: create and use 'knative-operator' namespace #6239

merged 1 commit into from
Apr 24, 2025

Conversation

SamuAlfageme
Copy link
Contributor

Proposed Changes

  • To make the equivalent between the manifests and helm installation.
  • Otherwise, following the steps on "Verify your Knative Operator installation" will fail.

@SamuAlfageme
Helm: create and use 'knative-operator' namespace
84880c5 
To make the equivalent between the manifests and helm installation.
@knative-prow knative-prow bot requested review from Leo6Leo and skonto March 20, 2025 10:59
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 20, 2025

Welcome @SamuAlfageme! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 84880c5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67dbf52067171b000845bcf6
😎 Deploy Preview https://deploy-preview-6239--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dprotaso
Copy link
Member

/assign @houshengbo

@dprotaso
Copy link
Member

bump @houshengbo

houshengbo
houshengbo reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, SamuAlfageme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@knative-prow knative-prow bot merged commit 3a2533f into knative:main Apr 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houshengbo houshengbo houshengbo left review comments

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@skonto skonto Awaiting requested review from skonto

Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuAlfageme @dprotaso @houshengbo