fix workflow get api returning error when the scanning is deleted (#4507)

jamsman94 · web-flow · commit ed7d7aa127af · 2026-02-11T10:22:31.000+08:00
Signed-off-by: Min Min &lt;jamsman94@gmail.com&gt;
diff --git a/pkg/microservice/aslan/core/workflow/service/workflow/workflow_v4.go b/pkg/microservice/aslan/core/workflow/service/workflow/workflow_v4.go
@@ -1356,8 +1356,8 @@ func ensureWorkflowV4JobResp(job *commonmodels.Job, logger *zap.SugaredLogger, b
 			}
 			scanningInfo, err := scanSvc.GetByName(projectName, scanning.Name)
 			if err != nil {
-				logger.Errorf(err.Error())
-				return e.ErrFindWorkflow.AddErr(err)
+				logger.Errorf("find scanning: %s error: %s", scanning.Name, err)
+				continue
 			}
 			scanning.KeyVals = commonservice.MergeBuildEnvs(scanningInfo.Envs.ToRuntimeList(), scanning.KeyVals)
 		}
@@ -1368,8 +1368,8 @@ func ensureWorkflowV4JobResp(job *commonmodels.Job, logger *zap.SugaredLogger, b
 			}
 			scanningInfo, err := scanSvc.GetByName(projectName, scanning.Name)
 			if err != nil {
-				logger.Errorf(err.Error())
-				return e.ErrFindWorkflow.AddErr(err)
+				logger.Errorf("find scanning: %s error: %s", scanning.Name, err)
+				continue
 			}
 			scanning.KeyVals = commonservice.MergeBuildEnvs(scanningInfo.Envs.ToRuntimeList(), scanning.KeyVals)
 		}

Original file line number	Diff line number	Diff line change
`@@ -1356,8 +1356,8 @@ func ensureWorkflowV4JobResp(job commonmodels.Job, logger zap.SugaredLogger, b`
`1356`	`1356`	`}`
`1357`	`1357`	`scanningInfo, err := scanSvc.GetByName(projectName, scanning.Name)`
`1358`	`1358`	`if err != nil {`
`1359`		`- logger.Errorf(err.Error())`
`1360`		`- return e.ErrFindWorkflow.AddErr(err)`
	`1359`	`+ logger.Errorf("find scanning: %s error: %s", scanning.Name, err)`
	`1360`	`+ continue`
`1361`	`1361`	`}`
`1362`	`1362`	`scanning.KeyVals = commonservice.MergeBuildEnvs(scanningInfo.Envs.ToRuntimeList(), scanning.KeyVals)`
`1363`	`1363`	`}`
`@@ -1368,8 +1368,8 @@ func ensureWorkflowV4JobResp(job commonmodels.Job, logger zap.SugaredLogger, b`
`1368`	`1368`	`}`
`1369`	`1369`	`scanningInfo, err := scanSvc.GetByName(projectName, scanning.Name)`
`1370`	`1370`	`if err != nil {`
`1371`		`- logger.Errorf(err.Error())`
`1372`		`- return e.ErrFindWorkflow.AddErr(err)`
	`1371`	`+ logger.Errorf("find scanning: %s error: %s", scanning.Name, err)`
	`1372`	`+ continue`
`1373`	`1373`	`}`
`1374`	`1374`	`scanning.KeyVals = commonservice.MergeBuildEnvs(scanningInfo.Envs.ToRuntimeList(), scanning.KeyVals)`
`1375`	`1375`	`}`